• Marius van der Wijden's avatar
    accounts/abi: simplify reflection logic (#21058) · f3f1e59e
    Marius van der Wijden authored
    * accounts/abi: simplified reflection logic
    
    * accounts/abi: simplified reflection logic
    
    * accounts/abi: removed unpack
    
    * accounts/abi: removed comments
    
    * accounts/abi: removed uneccessary complications
    
    * accounts/abi: minor changes in error messages
    
    * accounts/abi: removed unnused code
    
    * accounts/abi: fixed indexed argument unpacking
    
    * accounts/abi: removed superfluous test cases
    
    This commit removes two test cases. The first one is trivially invalid as we have the same
    test cases as passing in packing_test.go L375. The second one passes now,
    because we don't need the mapArgNamesToStructFields in unpack_atomic anymore.
    Checking for purely underscored arg names generally should not be something we do
    as the abi/contract is generally out of the control of the user.
    
    * accounts/abi: removed comments, debug println
    
    * accounts/abi: added commented out code
    
    * accounts/abi: addressed comments
    
    * accounts/abi: remove unnecessary dst.CanSet check
    
    * accounts/abi: added dst.CanSet checks
    f3f1e59e
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.golangci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
fuzzbuzz.yaml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
interfaces.go Loading commit data...