• Marius van der Wijden's avatar
    accounts/abi: simplify reflection logic (#21058) · f3f1e59e
    Marius van der Wijden authored
    * accounts/abi: simplified reflection logic
    
    * accounts/abi: simplified reflection logic
    
    * accounts/abi: removed unpack
    
    * accounts/abi: removed comments
    
    * accounts/abi: removed uneccessary complications
    
    * accounts/abi: minor changes in error messages
    
    * accounts/abi: removed unnused code
    
    * accounts/abi: fixed indexed argument unpacking
    
    * accounts/abi: removed superfluous test cases
    
    This commit removes two test cases. The first one is trivially invalid as we have the same
    test cases as passing in packing_test.go L375. The second one passes now,
    because we don't need the mapArgNamesToStructFields in unpack_atomic anymore.
    Checking for purely underscored arg names generally should not be something we do
    as the abi/contract is generally out of the control of the user.
    
    * accounts/abi: removed comments, debug println
    
    * accounts/abi: added commented out code
    
    * accounts/abi: addressed comments
    
    * accounts/abi: remove unnecessary dst.CanSet check
    
    * accounts/abi: added dst.CanSet checks
    f3f1e59e
Name
Last commit
Last update
..
abi Loading commit data...
external Loading commit data...
keystore Loading commit data...
scwallet Loading commit data...
usbwallet Loading commit data...
accounts.go Loading commit data...
accounts_test.go Loading commit data...
errors.go Loading commit data...
hd.go Loading commit data...
hd_test.go Loading commit data...
manager.go Loading commit data...
sort.go Loading commit data...
url.go Loading commit data...
url_test.go Loading commit data...