• Marius van der Wijden's avatar
    core: types: less allocations when hashing and tx handling (#21265) · ddeea1e0
    Marius van der Wijden authored
    * core, crypto: various allocation savings regarding tx handling
    
    * core: reduce allocs for gas price comparison
    
    This change reduces the allocations needed for comparing different transactions to each other.
    A call to `tx.GasPrice()` copies the gas price as it has to be safe against modifications and
    also needs to be threadsafe. For comparing and ordering different transactions we don't need
    these guarantees
    
    * core: added tx.GasPriceIntCmp for comparison without allocation
    
    adds a method to remove unneeded allocation in comparison to tx.gasPrice
    
    * core/types: pool legacykeccak256 objects in rlpHash
    
    rlpHash is by far the most used function in core that allocates a legacyKeccak256 object on each call.
    Since it is so widely used it makes sense to add pooling here so we relieve the GC.
    On my machine these changes result in > 100 MILLION less allocations and > 30 GB less allocated memory.
    
    * reverted some changes
    
    * reverted some changes
    
    * trie: use crypto.KeccakState instead of replicating code
    Co-authored-by: 's avatarMartin Holst Swende <martin@swende.se>
    ddeea1e0
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.golangci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
fuzzbuzz.yaml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
interfaces.go Loading commit data...