• Felix Lange's avatar
    p2p/simulations: fix a deadlock and clean up adapters (#17891) · dcae0d34
    Felix Lange authored
    This fixes a rare deadlock with the inproc adapter:
    
    - A node is stopped, which acquires Network.lock.
    - The protocol code being simulated (swarm/network in my case)
      waits for its goroutines to shut down.
    - One of those goroutines calls into the simulation to add a peer,
      which waits for Network.lock.
    
    The fix for the deadlock is really simple, just release the lock
    before stopping the simulation node.
    
    Other changes in this PR clean up the exec adapter so it reports
    node startup errors better and remove the docker adapter because
    it just adds overhead.
    
    In the exec adapter, node information is now posted to a one-shot
    server. This avoids log parsing and allows reporting startup
    errors to the simulation host.
    
    A small change in package node was needed because simulation
    nodes use port zero. Node.{HTTP,WS}Endpoint now return the live
    endpoints after startup by checking the TCP listener.
    dcae0d34
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
containers/docker Loading commit data...
contracts Loading commit data...
core Loading commit data...
crypto Loading commit data...
dashboard Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
vendor Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
interfaces.go Loading commit data...