• Janoš Guljaš's avatar
    swarm/pss: fix data race on HandshakeController.symKeyIndex (#19162) · 340a53a9
    Janoš Guljaš authored
    * swarm/pss: fix data race on HandshakeController.symKeyIndex
    
    The HandshakeController.symKeyIndex map was accessed concurrently.
    Since insufficient test coverage the race is not detected every time.
    However, running TestClientHandshake a 100 times seems to be enough to
    reproduce the race.
    
    Note: I've chosen HandshakeController.lock to protect
    HandshakeController.symKeyIndex as that was already protected in a few
    functions by that lock.
    
    Additionally:
    - removed unused testStore
    - enabled tests in handshake_test.go as they pass
    - removed code duplication by adding getSymKey()
    
    * swarm/pss: fix a data race on HandshakeController.keyC
    
    * swarm/pss: fix data races with on Pss.symKeyPool
    340a53a9
Name
Last commit
Last update
..
client Loading commit data...
notify Loading commit data...
testdata Loading commit data...
ARCHITECTURE.md Loading commit data...
README.md Loading commit data...
api.go Loading commit data...
doc.go Loading commit data...
forwarding_test.go Loading commit data...
handshake.go Loading commit data...
handshake_none.go Loading commit data...
handshake_test.go Loading commit data...
keystore.go Loading commit data...
ping.go Loading commit data...
protocol.go Loading commit data...
protocol_none.go Loading commit data...
protocol_test.go Loading commit data...
pss.go Loading commit data...
pss_test.go Loading commit data...
types.go Loading commit data...
writeup.md Loading commit data...