• Felix Lange's avatar
    metrics: improve reading Go runtime metrics (#25886) · c539bda1
    Felix Lange authored
    This changes how we read performance metrics from the Go runtime. Instead
    of using runtime.ReadMemStats, we now rely on the API provided by package
    runtime/metrics.
    
    runtime/metrics provides more accurate information. For example, the new
    interface has better reporting of memory use. In my testing, the reported
    value of held memory more accurately reflects the usage reported by the OS.
    
    The semantics of metrics system/memory/allocs and system/memory/frees have
    changed to report amounts in bytes. ReadMemStats only reported the count of
    allocations in number-of-objects. This is imprecise: 'tiny objects' are not
    counted because the runtime allocates them in batches; and certain
    improvements in allocation behavior, such as struct size optimizations,
    will be less visible when the number of allocs doesn't change.
    
    Changing allocation reports to be in bytes makes it appear in graphs that
    lots more is being allocated. I don't think that's a problem because this
    metric is primarily interesting for geth developers.
    
    The metric system/memory/pauses has been changed to report statistical
    values from the histogram provided by the runtime. Its name in influxdb has
    changed from geth.system/memory/pauses.meter to
    geth.system/memory/pauses.histogram.
    
    We also have a new histogram metric, system/cpu/schedlatency, reporting the
    Go scheduler latency.
    c539bda1
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
docs Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.golangci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
interfaces.go Loading commit data...
oss-fuzz.sh Loading commit data...