• James Prestwich's avatar
    accounts/usbwallet: mitigate ledger app chunking issue (#26773) · 1e3177de
    James Prestwich authored
    This PR mitigates an issue with Ledger's on-device RLP deserialization, see
    https://github.com/LedgerHQ/app-ethereum/issues/409
    
    Ledger's RLP deserialization code does not validate the length of the RLP list received,
    and it may prematurely enter the signing flow when a APDU chunk boundary falls immediately
    before the EIP-155 chain_id when deserializing a transaction. Since the chain_id is
    uninitialized, it is 0 during this signing flow. This may cause the user to accidentally
    sign the transaction with chain_id = 0. That signature would be returned from the device 1
    packet earlier than expected by the communication loop. The device blocks the
    second-to-last packet waiting for the signer flow, and then errors on the successive
    packet (which contains the chain_id, zeroed r, and zeroed s)
    
    Since the signature's early arrival causes successive errors during the communication
    process, geth does not parse the improper signature produced by the device, and therefore
    no improperly-signed transaction can be created. User funds are not at risk.
    
    We mitigate by selecting the highest chunk size that leaves at least 4 bytes in the
    final chunk.
    1e3177de
Name
Last commit
Last update
..
trezor Loading commit data...
hub.go Loading commit data...
ledger.go Loading commit data...
trezor.go Loading commit data...
wallet.go Loading commit data...