• gary rong's avatar
    all: seperate consensus error and evm internal error (#20830) · b9df7ecd
    gary rong authored
    * all: seperate consensus error and evm internal error
    
    There are actually two types of error will be returned when
    a tranaction/message call is executed: (a) consensus error
    (b) evm internal error. The former should be converted to
    a consensus issue, e.g. The sender doesn't enough asset to
    purchase the gas it specifies. The latter is allowed since
    evm itself is a blackbox and internal error is allowed to happen.
    
    This PR emphasizes the difference by introducing a executionResult
    structure. The evm error is embedded inside. So if any error
    returned, it indicates consensus issue happens.
    
    And also this PR improve the `EstimateGas` API to return the concrete
    revert reason if the transaction always fails
    
    * all: polish
    
    * accounts/abi/bind/backends: add tests
    
    * accounts/abi/bind/backends, internal: cleanup error message
    
    * all: address comments
    
    * core: fix lint
    
    * accounts, core, eth, internal: address comments
    
    * accounts, internal: resolve revert reason if possible
    
    * accounts, internal: address comments
    b9df7ecd
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.golangci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
fuzzbuzz.yaml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
interfaces.go Loading commit data...