• Felix Lange's avatar
    rlp: improve nil pointer handling (#20064) · 96fb8391
    Felix Lange authored
    * rlp: improve nil pointer handling
    
    In both encoder and decoder, the rules for encoding nil pointers were a
    bit hard to understand, and didn't leave much choice. Since RLP allows
    two empty values (empty list, empty string), any protocol built on RLP
    must choose either of these values to represent the null value in a
    certain context.
    
    This change adds choice in the form of two new struct tags, "nilString"
    and "nilList". These can be used to specify how a nil pointer value is
    encoded. The "nil" tag still exists, but its implementation is now
    explicit and defines exactly how nil pointers are handled in a single
    place.
    
    Another important change in this commit is how nil pointers and the
    Encoder interface interact. The EncodeRLP method was previously called
    even on nil values, which was supposed to give users a choice of how
    their value would be handled when nil. It turns out this is a stupid
    idea. If you create a network protocol containing an object defined in
    another package, it's better to be able to say that the object should be
    a list or string when nil in the definition of the protocol message
    rather than defining the encoding of nil on the object itself.
    
    As of this commit, the encoding rules for pointers now take precedence
    over the Encoder interface rule. I think the "nil" tag will work fine
    for most cases. For special kinds of objects which are a struct in Go
    but strings in RLP, code using the object can specify the desired
    encoding of nil using the "nilString" and "nilList" tags.
    
    * rlp: propagate struct field type errors
    
    If a struct contained fields of undecodable type, the encoder and
    decoder would panic instead of returning an error. Fix this by
    propagating type errors in makeStruct{Writer,Decoder} and add a test.
    96fb8391
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
dashboard Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
vendor Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
interfaces.go Loading commit data...