• Felix Lange's avatar
    all: unify big.Int zero checks, use common/math in more places (#3716) · 5f782627
    Felix Lange authored
    * common/math: optimize PaddedBigBytes, use it more
    
    name              old time/op    new time/op    delta
    PaddedBigBytes-8    71.1ns ± 5%    46.1ns ± 1%  -35.15%  (p=0.000 n=20+19)
    
    name              old alloc/op   new alloc/op   delta
    PaddedBigBytes-8     48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=20+20)
    
    * all: unify big.Int zero checks
    
    Various checks were in use. This commit replaces them all with Int.Sign,
    which is cheaper and less code.
    
    eg templates:
    
        func before(x *big.Int) bool { return x.BitLen() == 0 }
        func after(x *big.Int) bool  { return x.Sign() == 0 }
    
        func before(x *big.Int) bool { return x.BitLen() > 0 }
        func after(x *big.Int) bool  { return x.Sign() != 0 }
    
        func before(x *big.Int) int { return x.Cmp(common.Big0) }
        func after(x *big.Int) int  { return x.Sign() }
    
    * common/math, crypto/secp256k1: make ReadBits public in package math
    5f782627
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
compression/rle Loading commit data...
console Loading commit data...
containers Loading commit data...
contracts Loading commit data...
core Loading commit data...
crypto Loading commit data...
errs Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
pow Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
vendor Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
VERSION Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
interfaces.go Loading commit data...