• Martin Holst Swende's avatar
    accounts/external, internal/ethapi: fixes for London tx signing (#23274) · 5c13012b
    Martin Holst Swende authored
    Ticket #23273 found a flaw where we were unable to sign legacy-transactions
    using the external signer, even if we're still on non-london network. That's
    fixed in this PR.
    
    Additionally, I found that even when supplying all parameters, it was impossible
    to sign a london-transaction on an unsynched node. It's a pretty common usecase
    that someone wants to sign a transaction using an unsynced 'vanilla' node,
    providing all necessary data. Our setDefaults, however, insisted on checking the
    current block against the config. This PR therefore adds a case, so that if both
    MaxPriorityFeePerGas and MaxFeePerGas are provided, we accept them as given.
    
    OBS This PR fixes a regression -- on current master, we are unable to sign a
    london-transaction unless the node is synched, which may break scenarios where
    geth (or clef) is used as a cold wallet.
    
    Fixes #23273 
    5c13012b
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.golangci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
interfaces.go Loading commit data...
oss-fuzz.sh Loading commit data...