• Felix Lange's avatar
    rpc: tighter shutdown synchronization in client subscription (#22597) · 4a37ae51
    Felix Lange authored
    This fixes a rare issue where the client subscription forwarding loop
    would attempt send on the subscription's channel after Unsubscribe has
    returned, leading to a panic if the subscription channel was already
    closed by the user. Example:
    
        sub, _ := client.Subscribe(..., channel, ...)
        sub.Unsubscribe()
        close(channel)
    
    The race occurred because Unsubscribe called quitWithServer to tell the
    forwarding loop to stop sending on sub.channel, but did not wait for the
    loop to actually come down. This is fixed by adding an additional channel
    to track the shutdown, on which Unsubscribe now waits.
    
    Fixes #22322
    4a37ae51
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts/checkpointoracle Loading commit data...
core Loading commit data...
crypto Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.golangci.yml Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
interfaces.go Loading commit data...
oss-fuzz.sh Loading commit data...