• Ferenc Szabo's avatar
    cmd/swarm: fix resource leaks in tests (#19443) · 26b50e3e
    Ferenc Szabo authored
    * swarm/api: fix file descriptor leak in NewTestSwarmServer
    
    Swarm storage (localstore) was not closed. That resulted a
    "too many open files" error if `TestClientUploadDownloadRawEncrypted`
    was run with `-count 1000`.
    
    * cmd/swarm: speed up StartNewNodes() by parallelization
    
    Reduce cluster startup time from 13s to 7s.
    
    * swarm/api: disable flaky TestClientUploadDownloadRawEncrypted with -race
    
    * swarm/storage: disable flaky TestLDBStoreCollectGarbage (-race)
    
    With race detection turned on the disabled cases often fail with:
    "ldbstore_test.go:535: expected surplus chunk 150 to be missing, but got no error"
    
    * cmd/swarm: fix process leak in TestACT and TestSwarmUp
    
    Each test run we start 3 nodes, but we did not terminate them. So
    those 3 nodes continued eating up 1.2GB (3.4GB with -race) after test
    completion.
    
    6b6c4d1c changed how we start clusters
    to speed up tests. The changeset merged together test cases
    and introduced a global cluster. But "forgot" about termination.
    
    Let's get rid of "global cluster" so we have a clear owner of
    termination (some time sacrifice), while leaving subtests to use the
    same cluster.
    26b50e3e
Name
Last commit
Last update
..
client.go Loading commit data...
client_test.go Loading commit data...