• Ferenc Szabo's avatar
    cmd/swarm: fix resource leaks in tests (#19443) · 26b50e3e
    Ferenc Szabo authored
    * swarm/api: fix file descriptor leak in NewTestSwarmServer
    
    Swarm storage (localstore) was not closed. That resulted a
    "too many open files" error if `TestClientUploadDownloadRawEncrypted`
    was run with `-count 1000`.
    
    * cmd/swarm: speed up StartNewNodes() by parallelization
    
    Reduce cluster startup time from 13s to 7s.
    
    * swarm/api: disable flaky TestClientUploadDownloadRawEncrypted with -race
    
    * swarm/storage: disable flaky TestLDBStoreCollectGarbage (-race)
    
    With race detection turned on the disabled cases often fail with:
    "ldbstore_test.go:535: expected surplus chunk 150 to be missing, but got no error"
    
    * cmd/swarm: fix process leak in TestACT and TestSwarmUp
    
    Each test run we start 3 nodes, but we did not terminate them. So
    those 3 nodes continued eating up 1.2GB (3.4GB with -race) after test
    completion.
    
    6b6c4d1c changed how we start clusters
    to speed up tests. The changeset merged together test cases
    and introduced a global cluster. But "forgot" about termination.
    
    Let's get rid of "global cluster" so we have a clear owner of
    termination (some time sacrifice), while leaving subtests to use the
    same cluster.
    26b50e3e
Name
Last commit
Last update
.github Loading commit data...
accounts Loading commit data...
build Loading commit data...
cmd Loading commit data...
common Loading commit data...
consensus Loading commit data...
console Loading commit data...
contracts Loading commit data...
core Loading commit data...
crypto Loading commit data...
dashboard Loading commit data...
docs/audits Loading commit data...
eth Loading commit data...
ethclient Loading commit data...
ethdb Loading commit data...
ethstats Loading commit data...
event Loading commit data...
graphql Loading commit data...
internal Loading commit data...
les Loading commit data...
light Loading commit data...
log Loading commit data...
metrics Loading commit data...
miner Loading commit data...
mobile Loading commit data...
node Loading commit data...
p2p Loading commit data...
params Loading commit data...
rlp Loading commit data...
rpc Loading commit data...
signer Loading commit data...
swarm Loading commit data...
tests Loading commit data...
trie Loading commit data...
vendor Loading commit data...
whisper Loading commit data...
.dockerignore Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LESSER Loading commit data...
Dockerfile Loading commit data...
Dockerfile.alltools Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
appveyor.yml Loading commit data...
circle.yml Loading commit data...
interfaces.go Loading commit data...