• Martin Holst Swende's avatar
    all: more linters (#24783) · a907d7e8
    Martin Holst Swende authored
    This enables the following linters
    
    - typecheck
    - unused
    - staticcheck
    - bidichk
    - durationcheck
    - exportloopref
    - gosec
    
    WIth a few exceptions.
    
    - We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there.
    - The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now.
    - Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention.
    - The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees.
    Unverified
    a907d7e8
Name
Last commit
Last update
..
testdata Loading commit data...
client.go Loading commit data...
client_example_test.go Loading commit data...
client_test.go Loading commit data...
constants_unix.go Loading commit data...
constants_unix_nocgo.go Loading commit data...
doc.go Loading commit data...
endpoints.go Loading commit data...
errors.go Loading commit data...
handler.go Loading commit data...
http.go Loading commit data...
http_test.go Loading commit data...
inproc.go Loading commit data...
ipc.go Loading commit data...
ipc_js.go Loading commit data...
ipc_unix.go Loading commit data...
ipc_windows.go Loading commit data...
json.go Loading commit data...
metrics.go Loading commit data...
server.go Loading commit data...
server_test.go Loading commit data...
service.go Loading commit data...
stdio.go Loading commit data...
subscription.go Loading commit data...
subscription_test.go Loading commit data...
testservice_test.go Loading commit data...
types.go Loading commit data...
types_test.go Loading commit data...
websocket.go Loading commit data...
websocket_test.go Loading commit data...