Co-authored-by: Martin Holst Swende <martin@swende.se>

Signed-off-by: jsvisa <delweng@gmail.com>

rpc: use atomic type

Sets a meaningful name on test-files

* cmd, miner, singer: avoid panic if keystore is not available

* cmd/geth: print warning instead of panic

Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8

---------
Co-authored-by: Martin Holst Swende <martin@swende.se>

This PR adds a check that the safetxhash that we sign corresponds to the one that is expected by the input. If it differs, it tries again with the configured chainid. 

This PR should makes it easier to sign EIP-712 typed data via the accounts.Wallet API, by using the mimetype for typed data. 
Co-authored-by: nasdf <keenan.nemetz@gmail.com>

PR #26082 added account listing to OnSignerStartup but did not consider the case where a user has a large number of accounts which would be annoying to display.

This PR updates showAccounts() so that if there are more than 20 accounts available the user sees the first 20 displayed in the console followed by: First 20 accounts listed (N more available).
Co-authored-by: Martin Holst Swende <martin@swende.se>

Reports accounts known to Clef during startup, after master seed is provided by the user.

* apitypes: synchronize handling of types

* signer/core/apitypes: improve array check

* apitypes: add a test for big.Int -> int32

* signer/core/apitypes: Add a test for parsing addresses from [20]byte, []byte and string

* signer/core/apitypes: add some testcases
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>

This changes the CI / release builds to use the latest Go version. It also
upgrades golangci-lint to a newer version compatible with Go 1.19.

In Go 1.19, godoc has gained official support for links and lists. The
syntax for code blocks in doc comments has changed and now requires a
leading tab character. gofmt adapts comments to the new syntax
automatically, so there are a lot of comment re-formatting changes in this
PR. We need to apply the new format in order to pass the CI lint stage with
Go 1.19.

With the linter upgrade, I have decided to disable 'gosec' - it produces
too many false-positive warnings. The 'deadcode' and 'varcheck' linters
have also been removed because golangci-lint warns about them being
unmaintained. 'unused' provides similar coverage and we already have it
enabled, so we don't lose much with this change.

* Fix some typos

* Fix some mistakes

* Revert 4byte.json

* Fix an incorrect fix

* Change files to fails

signer/rules: register clef api properly when rules are used, fixes #25298

* golangci: typo
Signed-off-by: Delweng <delweng@gmail.com>

* golangci: add whietspace
Signed-off-by: Delweng <delweng@gmail.com>

* *: rm whitesapce using golangci-lint
Signed-off-by: Delweng <delweng@gmail.com>

* cmd/puppeth: revert accidental resurrection
Co-authored-by: Péter Szilágyi <peterke@gmail.com>

I have a EIP712 typehash using uint96, but it's currently not supported
by go-ethereum. This change fixes it.

minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx`

* signer/core: always pad clique header extra data with space for sealer's signature

* capitalize comment

Co-authored-by: Martin Holst Swende <martin@swende.se>

This adds a tools.go file to import all command packages used for
go:generate. Doing so makes it possible to execute go-based code
generators using 'go run', locking in the tool version using go.mod.
Co-authored-by: Felix Lange <fjl@twurst.com>

This commit replaces ioutil.TempDir with t.TempDir in tests. The
directory created by t.TempDir is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using ioutil.TempDir
had to be removed manually by calling os.RemoveAll, which is omitted in
some tests. The error handling boilerplate e.g.

	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}

is also tedious, but t.TempDir handles this for us nicely.

Reference: https://pkg.go.dev/testing#T.TempDirSigned-off-by: Eng Zer Jun <engzerjun@gmail.com>

This replaces the simple selector parser in signer/fourbyte with one that
can actually handle most types. The new parser is added in accounts/abi
to also make it useable elsewhere.

Co-authored-by: specerxi <xhxpecer@gmail.com>

* fix blocking and non-blocking issues

* core: revert change in blockchain.go
Co-authored-by: Martin Holst Swende <martin@swende.se>

This replaces the sketchy and undocumented string context keys for HTTP requests
with a defined interface. Using string keys with context is discouraged because
they may clash with keys created by other packages.

We added these keys to make connection metadata available in the signer, so this
change also updates signer/core to use the new PeerInfo API.

Fixes #23972

This doesn't fix all go-critic warnings, just the most serious ones.
Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>