1. 06 Jun, 2016 1 commit
    • Thomas Bocek's avatar
      accounts/abi: Negative numbers not properly converted in ABI encoding · 89c6c5bb
      Thomas Bocek authored
      When converting a negative number e.g., -2, the resulting ABI encoding
      should look as follows:
      fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe.
      However, since the check of the type is for an uint instead of an
      int, it results in the following ABI encoding:
      0101010101010101010101010101010101010101010101010101010101010102. The
      Ethereum ABI
      (https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI) says,
      that signed integers are stored in two's complement which should be
      of the form ffffff.... and not 01010101..... for e.g. -1. Thus, I
      removed the type check in numbers.go as well as the function S256
      as I don't think they are correct. Or maybe I'm missing something?
      89c6c5bb
  2. 31 May, 2016 4 commits
  3. 30 May, 2016 4 commits
  4. 27 May, 2016 3 commits
  5. 26 May, 2016 1 commit
  6. 25 May, 2016 6 commits
  7. 24 May, 2016 2 commits
  8. 23 May, 2016 5 commits
  9. 22 May, 2016 1 commit
  10. 20 May, 2016 5 commits
  11. 19 May, 2016 1 commit
  12. 18 May, 2016 3 commits
  13. 17 May, 2016 4 commits