1. 17 Nov, 2022 4 commits
  2. 16 Nov, 2022 3 commits
  3. 15 Nov, 2022 1 commit
    • Felix Lange's avatar
      rpc: fix connection tracking set in Server (#26180) · ae421480
      Felix Lange authored
      rpc: fix connection tracking in Server
      
      When upgrading to mapset/v2 with generics, the set element type used in
      rpc.Server had to be changed to *ServerCodec because ServerCodec is not
      'comparable'. While the distinction is technically correct, we know all
      possible ServerCodec types, and all of them are comparable. So just use
      a map instead.
      ae421480
  4. 14 Nov, 2022 4 commits
  5. 11 Nov, 2022 5 commits
    • Martin Holst Swende's avatar
      common/lru: fix race in lru (#26164) · 8334b5f5
      Martin Holst Swende authored
      This fixes a problem in the SizeConstrainedLRU. The SCLRU uses an underlying simple lru which is not thread safe.
      During the Get operation, the recentness of the accessed item is updated, so it is not a pure read-operation. Therefore, the mutex we need is a full mutex, not RLock.
      
      This PR changes the mutex to be a regular Mutex, instead of RWMutex, so a reviewer can at a glance see that all affected locations are fixed.
      8334b5f5
    • Martin Holst Swende's avatar
      eth, catalyst: fix flaky tests (#26153) · ea65edaa
      Martin Holst Swende authored
      * eth/catalyst: fix time-dependent (flaky) test
      
      * eth: increase timeout on TestTransactionPropagation
      ea65edaa
    • Felix Lange's avatar
      metrics: improve reading Go runtime metrics (#25886) · c539bda1
      Felix Lange authored
      This changes how we read performance metrics from the Go runtime. Instead
      of using runtime.ReadMemStats, we now rely on the API provided by package
      runtime/metrics.
      
      runtime/metrics provides more accurate information. For example, the new
      interface has better reporting of memory use. In my testing, the reported
      value of held memory more accurately reflects the usage reported by the OS.
      
      The semantics of metrics system/memory/allocs and system/memory/frees have
      changed to report amounts in bytes. ReadMemStats only reported the count of
      allocations in number-of-objects. This is imprecise: 'tiny objects' are not
      counted because the runtime allocates them in batches; and certain
      improvements in allocation behavior, such as struct size optimizations,
      will be less visible when the number of allocs doesn't change.
      
      Changing allocation reports to be in bytes makes it appear in graphs that
      lots more is being allocated. I don't think that's a problem because this
      metric is primarily interesting for geth developers.
      
      The metric system/memory/pauses has been changed to report statistical
      values from the histogram provided by the runtime. Its name in influxdb has
      changed from geth.system/memory/pauses.meter to
      geth.system/memory/pauses.histogram.
      
      We also have a new histogram metric, system/cpu/schedlatency, reporting the
      Go scheduler latency.
      c539bda1
    • Felix Lange's avatar
      go.mod: minimum Go version 1.18 (#26160) · 62c973eb
      Felix Lange authored
      This will allow use of generics and other new standard library APIs
      such as package net/netip.
      62c973eb
    • Felix Lange's avatar
      internal/debug: add --log.file option (#26149) · 5b4c149f
      Felix Lange authored
      This adds an option to direct log output to a file. This feature has been
      requested a lot. It's sometimes useful to have this available when running
      geth in an environment that doesn't easily allow redirecting the output.
      
      Notably, there is no support for log rotation with this change. The --log.file option
      opens the file once on startup and then keeps writing to the file handle. 
      This can become an issue when external log rotation tools are involved, so it's
      best not to use them with this option for now.
      5b4c149f
  6. 10 Nov, 2022 1 commit
  7. 09 Nov, 2022 4 commits
  8. 08 Nov, 2022 6 commits
  9. 07 Nov, 2022 6 commits
  10. 06 Nov, 2022 1 commit
  11. 04 Nov, 2022 3 commits
  12. 03 Nov, 2022 2 commits