- 07 Mar, 2023 6 commits
-
-
James Prestwich authored
This PR mitigates an issue with Ledger's on-device RLP deserialization, see https://github.com/LedgerHQ/app-ethereum/issues/409 Ledger's RLP deserialization code does not validate the length of the RLP list received, and it may prematurely enter the signing flow when a APDU chunk boundary falls immediately before the EIP-155 chain_id when deserializing a transaction. Since the chain_id is uninitialized, it is 0 during this signing flow. This may cause the user to accidentally sign the transaction with chain_id = 0. That signature would be returned from the device 1 packet earlier than expected by the communication loop. The device blocks the second-to-last packet waiting for the signer flow, and then errors on the successive packet (which contains the chain_id, zeroed r, and zeroed s) Since the signature's early arrival causes successive errors during the communication process, geth does not parse the improper signature produced by the device, and therefore no improperly-signed transaction can be created. User funds are not at risk. We mitigate by selecting the highest chunk size that leaves at least 4 bytes in the final chunk.
-
Sina Mahmoodi authored
Fixes #26073
-
Guruprasad Kamath authored
Fixes a minor error in the testdata
-
Adrian Sutton authored
Checks that Transaction.MarshalJSON and newRPCTransaction JSON output can be parsed by Transaction.UnmarshalJSON --------- Co-authored-by:
Martin Holst Swende <martin@swende.se>
-
rjl493456442 authored
This change fixes a flaw where, in certain scenarios, the block sealer did not accurately reset the remaining gas after failing to include an invalid transaction. Fixes #26791
-
Felix Lange authored
This fixes a regression introduced by #26723. Fixes #26816.
-
- 06 Mar, 2023 5 commits
-
-
turboboost55 authored
This PR changes metrics collection to actually measure the time interval between collections, rather than assume 3 seconds. I did some ad hoc profiling, and on slower hardware (eg, my Raspberry Pi 4) I routinely saw intervals between 3.3 - 3.5 seconds, with some being as high as 4.5 seconds. This will generally cause the CPU gauge readings to be too high, and in some cases can cause impossibly large values for the CPU load metrics (eg. greater than 400 for a 4 core CPU). --------- Co-authored-by:
Felix Lange <fjl@twurst.com>
-
Marius van der Wijden authored
Fixes a race in TestNewPayloadOnInvalidTerminalBlock where setting the TTD raced with the miner. Solution: set the TTD on the blockchain config not the genesis config. Also fixes a race in CopyHeader which resulted in race reports all over the place.
-
Felix Lange authored
This change adds a struct field EffectiveGasPrice in types.Receipt. The field is present in RPC responses, but not in the Go struct, and thus can't easily be accessed via ethclient. Co-authored-by:
PulsarAI <dev@pulsar-systems.fi>
-
Péter Szilágyi authored
-
Marius van der Wijden authored
* core: params: schedule Shanghai on goerli * core/forkid: fix comment
-
- 03 Mar, 2023 4 commits
-
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
- 02 Mar, 2023 1 commit
-
-
Péter Szilágyi authored
-
- 28 Feb, 2023 5 commits
-
-
Peter (bitfly) authored
* include withdrawals in ethclient responses * omit empty withdrawals array in json serialization
-
rjl493456442 authored
-
rjl493456442 authored
* ethdb/pebble: fix range compaction * ethdb/pebble: add comment
-
Dan Cline authored
This fixes an issue where the withdrawal index was not calculated correctly for multiple withdrawals in a single block. Co-authored-by:
Gary Rong <garyrong0905@gmail.com> Co-authored-by:
Felix Lange <fjl@twurst.com>
-
Chris Ziogas authored
Adds support for a native call tracer with the Parity format, which outputs call frames in a flat array. This tracer accepts the following options: - `convertParityErrors: true` will convert error messages to match those of Parity - `includePrecompiles: true` will report all calls to precompiles. The default matches Parity's behavior where CALL and STATICCALLs to precompiles are excluded Incompatibilities with Parity include: - Parity removes the result object in case of failure. This behavior is maintained with the exception of reverts. Revert output usually contains useful information, i.e. Solidity revert reason. - The `gasUsed` field accounts for intrinsic gas (e.g. 21000 for simple transfers) and refunds unlike Parity - Block rewards are not reported Co-authored-by:
Sina Mahmoodi <itz.s1na@gmail.com>
-
- 27 Feb, 2023 1 commit
-
-
Martin Holst Swende authored
This improves the speed of DHT crawling by using concurrent requests. It also removes logging of individual DNS updates.
-
- 23 Feb, 2023 3 commits
-
-
Péter Szilágyi authored
ci: disable coverage reporting in appveyor and travis
-
Péter Szilágyi authored
-
Martin Holst Swende authored
-
- 22 Feb, 2023 5 commits
-
-
Nate Armstrong authored
Add usage examples
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
Yier authored
* eth/filters: fix a breaking change and return rpctransaction * eth/filters: fix test cases --------- Co-authored-by:
Catror <me@catror.com>
-
- 21 Feb, 2023 5 commits
-
-
rjl493456442 authored
The EmptyRootHash and EmptyCodeHash are defined everywhere in the codebase, this PR replaces all of them with unified one defined in core/types package, and also defines constants for TxRoot, WithdrawalsRoot and UncleRoot
-
Péter Szilágyi authored
-
Martin Holst Swende authored
-
Péter Szilágyi authored
-
Sungwoo Kim authored
Clarifies the documentation around dumpconfi Signed-off-by:
Sungwoo Kim <git@sung-woo.kim>
-
- 20 Feb, 2023 5 commits
-
-
rjl493456442 authored
This reverts commit 7c749c94.
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-
Péter Szilágyi authored
-