whisper: remove dead code, rename a few constants

whisper/peer.go

@@ -88,8 +88,8 @@ func (self *peer) handshake() error {
 // and expiration.
 func (self *peer) update() {
 	// Start the tickers for the updates
-	expire := time.NewTicker(expirationTicks)
-	transmit := time.NewTicker(transmissionTicks)
+	expire := time.NewTicker(expirationCycle)
+	transmit := time.NewTicker(transmissionCycle)
 
 	// Loop and transmit until termination is requested
 	for {

whisper/peer_test.go

@@ -185,7 +185,7 @@ func TestPeerDeliver(t *testing.T) {
 		t.Fatalf("failed to transfer message: %v", err)
 	}
 	select {
-	case <-time.After(2 * transmissionTicks):
+	case <-time.After(2 * transmissionCycle):
 	case <-arrived:
 		t.Fatalf("repeating message arrived")
 	}

whisper/sort.go

-package whisper
-
-import (
-	"sort"
-
-	"github.com/ethereum/go-ethereum/common"
-)
-
-type sortedKeys struct {
-	k []int32
-}
-
-func (self *sortedKeys) Len() int           { return len(self.k) }
-func (self *sortedKeys) Less(i, j int) bool { return self.k[i] < self.k[j] }
-func (self *sortedKeys) Swap(i, j int)      { self.k[i], self.k[j] = self.k[j], self.k[i] }
-
-func sortKeys(m map[int32]common.Hash) []int32 {
-	sorted := new(sortedKeys)
-	sorted.k = make([]int32, len(m))
-	i := 0
-	for key, _ := range m {
-		sorted.k[i] = key
-		i++
-	}
-
-	sort.Sort(sorted)
-
-	return sorted.k
-}

whisper/sort_test.go

-package whisper
-
-import (
-	"testing"
-
-	"github.com/ethereum/go-ethereum/common"
-)
-
-func TestSorting(t *testing.T) {
-	m := map[int32]common.Hash{
-		1: {1},
-		3: {3},
-		2: {2},
-		5: {5},
-	}
-	exp := []int32{1, 2, 3, 5}
-	res := sortKeys(m)
-	for i, k := range res {
-		if k != exp[i] {
-			t.Error(k, "failed. Expected", exp[i])
-		}
-	}
-}

whisper/whisper.go

@@ -25,8 +25,8 @@ const (
 	signatureFlag   = byte(1 << 7)
 	signatureLength = 65
 
-	expirationTicks   = 800 * time.Millisecond
-	transmissionTicks = 300 * time.Millisecond
+	expirationCycle   = 800 * time.Millisecond
+	transmissionCycle = 300 * time.Millisecond
 )
 
 const (
@@ -275,7 +275,7 @@ func createFilter(message *Message, topics []Topic) filter.Filter {
 // state by expiring stale messages from the pool.
 func (self *Whisper) update() {
 	// Start a ticker to check for expirations
-	expire := time.NewTicker(expirationTicks)
+	expire := time.NewTicker(expirationCycle)
 
 	// Repeat updates until termination is requested
 	for {

whisper/whisper_test.go

@@ -178,7 +178,7 @@ func TestMessageExpiration(t *testing.T) {
 	}
 	// Wait for expiration and check cache again
 	time.Sleep(time.Second)     // wait for expiration
-	time.Sleep(expirationTicks) // wait for cleanup cycle
+	time.Sleep(expirationCycle) // wait for cleanup cycle
 	if _, ok := node.messages[envelope.Hash()]; ok {
 		t.Fatalf("message not expired from cache")
 	}