Merge pull request #14897 from karalabe/cardinal-sin

cmd/puppeth: remove wrapping loop in single reads

cmd/puppeth/wizard.go

@@ -106,7 +106,6 @@ func (w *wizard) readString() string {
 // readDefaultString reads a single line from stdin, trimming if from spaces. If
 // an empty line is entered, the default value is returned.
 func (w *wizard) readDefaultString(def string) string {
-	for {
 	fmt.Printf("> ")
 	text, err := w.in.ReadString('\n')
 	if err != nil {
@@ -116,7 +115,6 @@ func (w *wizard) readDefaultString(def string) string {
 		return text
 	}
 	return def
-	}
 }
 
 // readInt reads a single line from stdin, trimming if from spaces, enforcing it
@@ -207,7 +205,6 @@ func (w *wizard) readDefaultFloat(def float64) float64 {
 // readPassword reads a single line from stdin, trimming it from the trailing new
 // line and returns it. The input will not be echoed.
 func (w *wizard) readPassword() string {
-	for {
 	fmt.Printf("> ")
 	text, err := terminal.ReadPassword(int(syscall.Stdin))
 	if err != nil {
@@ -215,7 +212,6 @@ func (w *wizard) readPassword() string {
 	}
 	fmt.Println()
 	return string(text)
-	}
 }
 
 // readAddress reads a single line from stdin, trimming if from spaces and converts