contract.js simplified

lib/contract.js

@@ -22,78 +22,35 @@
 
 var web3 = require('./web3'); 
 var abi = require('./abi');
+var eventImplementation = require('./event');
 
-/**
- * This method should be called when we want to call / transact some solidity method from javascript
- * it returns an object which has same methods available as solidity contract description
- * usage example: 
- *
- * var abi = [{
- *      name: 'myMethod',
- *      inputs: [{ name: 'a', type: 'string' }],
- *      outputs: [{name: 'd', type: 'string' }]
- * }];  // contract abi
- *
- * var myContract = web3.eth.contract('0x0123123121', abi); // creation of contract object
- *
- * myContract.myMethod('this is test string param for call'); // myMethod call (implicit, default)
- * myContract.call().myMethod('this is test string param for call'); // myMethod call (explicit)
- * myContract.transact().myMethod('this is test string param for transact'); // myMethod transact
- *
- * @param address - address of the contract, which should be called
- * @param desc - abi json description of the contract, which is being created
- * @returns contract object
- */
-
-var contract = function (address, desc) {
-
-    desc.forEach(function (method) {
-        // workaround for invalid assumption that method.name is the full anonymous prototype of the method.
-        // it's not. it's just the name. the rest of the code assumes it's actually the anonymous
-        // prototype, so we make it so as a workaround.
-        // TODO: we may not want to modify input params, maybe use copy instead?
-        if (method.name.indexOf('(') === -1) {
-            var displayName = method.name;
-            var typeName = method.inputs.map(function(i){return i.type; }).join();
-            method.name = displayName + '(' + typeName + ')';
-        }
-    });
-
-    var inputParser = abi.inputParser(desc);
-    var outputParser = abi.outputParser(desc);
-
-    var result = {
-        address: address,
-    };
-
-    Object.defineProperty(result, 'topics', {
-        get: function() {
-            return abi.filterEvents(desc).map(function (event) {
-                return abi.methodSignature(event.name);
-            });
-        }
-    });
-
-    result.call = function (options) {
-        result._isTransact = false;
-        result._options = options;
-        return result;
+var addFunctionRelatedPropertiesToContract = function (contract) {
+    
+    contract.call = function (options) {
+        contract._isTransact = false;
+        contract._options = options;
+        return contract;
     };
 
-    result.transact = function (options) {
-        result._isTransact = true;
-        result._options = options;
-        return result;
+    contract.transact = function (options) {
+        contract._isTransact = true;
+        contract._options = options;
+        return contract;
     };
 
-    result._options = {};
+    contract._options = {};
     ['gas', 'gasPrice', 'value', 'from'].forEach(function(p) {
-        result[p] = function (v) {
-            result._options[p] = v;
-            return result;
+        contract[p] = function (v) {
+            contract._options[p] = v;
+            return contract;
         };
     });
 
+};
+
+var addFunctionsToContract = function (contract, desc, address) {
+    var inputParser = abi.inputParser(desc);
+    var outputParser = abi.outputParser(desc);
 
     // create contract functions
     abi.filterFunctions(desc).forEach(function (method) {
@@ -106,16 +63,16 @@ var contract = function (address, desc) {
             var signature = abi.methodSignature(method.name);
             var parsed = inputParser[displayName][typeName].apply(null, params);
 
-            var options = result._options || {};
+            var options = contract._options || {};
             options.to = address;
             options.data = signature + parsed;
             
-            var isTransact = result._isTransact === true || (result._isTransact !== false && !method.constant);
+            var isTransact = contract._isTransact === true || (contract._isTransact !== false && !method.constant);
             var collapse = options.collapse !== false;
             
             // reset
-            result._options = {};
-            result._isTransact = null;
+            contract._options = {};
+            contract._isTransact = null;
 
             if (isTransact) {
                 // it's used byt natspec.js
@@ -142,40 +99,96 @@ var contract = function (address, desc) {
             return ret;
         };
 
-        if (result[displayName] === undefined) {
-            result[displayName] = impl;
+        if (contract[displayName] === undefined) {
+            contract[displayName] = impl;
         }
 
-        result[displayName][typeName] = impl;
-
+        contract[displayName][typeName] = impl;
     });
+};
 
-
-    // create contract events
-    abi.filterEvents(desc).forEach(function (event) {
+var addEventRelatedPropertiesToContract = function (contract, desc, address) {
+    contract.address = address;
     
-        // TODO: rename these methods, cause they are used not only for methods
-        var displayName = abi.methodDisplayName(event.name);
-        var typeName = abi.methodTypeName(event.name);
+    Object.defineProperty(contract, 'topics', {
+        get: function() {
+            return abi.filterEvents(desc).map(function (e) {
+                return abi.methodSignature(e.name);
+            });
+        }
+    });
 
+};
 
-        var impl = function (options) {
-            var signature = abi.methodSignature(event.name);
-            var o = options || {};
-            o.address = o.address || address;
-            o.topics = o.topics || [];
-            o.topics.push(signature);
+var addEventsToContract = function (contract, desc, address) {
+    // create contract events
+    abi.filterEvents(desc).forEach(function (e) {
 
+        var impl = function () {
+            var params = Array.prototype.slice.call(arguments);
+            var signature = abi.methodSignature(e.name);
+            var eventImpl = eventImplementation(address, signature);
+            var o = eventImpl.apply(null, params);
             return web3.eth.watch(o);  
         };
+        
+        // TODO: rename these methods, cause they are used not only for methods
+        var displayName = abi.methodDisplayName(e.name);
+        var typeName = abi.methodTypeName(e.name);
 
-        if (result[displayName] === undefined) {
-            result[displayName] = impl;
+        if (contract[displayName] === undefined) {
+            contract[displayName] = impl;
         }
 
-        result[displayName][typeName] = impl;
+        contract[displayName][typeName] = impl;
 
     });
+};
+
+
+/**
+ * This method should be called when we want to call / transact some solidity method from javascript
+ * it returns an object which has same methods available as solidity contract description
+ * usage example: 
+ *
+ * var abi = [{
+ *      name: 'myMethod',
+ *      inputs: [{ name: 'a', type: 'string' }],
+ *      outputs: [{name: 'd', type: 'string' }]
+ * }];  // contract abi
+ *
+ * var myContract = web3.eth.contract('0x0123123121', abi); // creation of contract object
+ *
+ * myContract.myMethod('this is test string param for call'); // myMethod call (implicit, default)
+ * myContract.call().myMethod('this is test string param for call'); // myMethod call (explicit)
+ * myContract.transact().myMethod('this is test string param for transact'); // myMethod transact
+ *
+ * @param address - address of the contract, which should be called
+ * @param desc - abi json description of the contract, which is being created
+ * @returns contract object
+ */
+
+var contract = function (address, desc) {
+
+    desc.forEach(function (method) {
+        // workaround for invalid assumption that method.name is the full anonymous prototype of the method.
+        // it's not. it's just the name. the rest of the code assumes it's actually the anonymous
+        // prototype, so we make it so as a workaround.
+        // TODO: we may not want to modify input params, maybe use copy instead?
+        if (method.name.indexOf('(') === -1) {
+            var displayName = method.name;
+            var typeName = method.inputs.map(function(i){return i.type; }).join();
+            method.name = displayName + '(' + typeName + ')';
+        }
+    });
+
+
+
+    var result = {};
+    addFunctionRelatedPropertiesToContract(result);
+    addFunctionsToContract(result, desc, address);
+    addEventRelatedPropertiesToContract(result, desc, address);
+    addEventsToContract(result, desc, address);
 
     return result;
 };

lib/event.js

 
 var abi = require('./abi');
 
-var implementationOfEvent = function (event, address, signature) {
+var implementationOfEvent = function (address, signature) {
     
     return function (options) {
         var o = options || {};

test/event.js

@@ -7,13 +7,9 @@ describe('event', function () {
         // given
         var address = '0x012345'; 
         var signature = '0x987654';
-        var e = {
-            name: 'test',
-            type: 'event',
-        };
 
         // when
-        var impl = event(e, address, signature);
+        var impl = event(address, signature);
         var result = impl();
 
         // then
@@ -23,3 +19,4 @@ describe('event', function () {
 
     });
 });
+