p2p/server: add UDP port mapping goroutine to wait group (#20846)

bf35e27e · ucwong · GitHub · 1e2e1b41 · bf35e27e
Unverified Commit bf35e27e authored Apr 01, 2020 by ucwong Committed by GitHub Apr 01, 2020
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

server.go p2p/server.go +5 -1

No files found.
--- a/p2p/server.go
+++ b/p2p/server.go
@@ -562,7 +562,11 @@ func (srv *Server) setupDiscovery() error {
 	srv.log.Debug("UDP listener up", "addr", realaddr)
 	if srv.NAT != nil {
 		if !realaddr.IP.IsLoopback() {
-			go nat.Map(srv.NAT, srv.quit, "udp", realaddr.Port, realaddr.Port, "ethereum discovery")
+			srv.loopWG.Add(1)
+			go func() {
+				nat.Map(srv.NAT, srv.quit, "udp", realaddr.Port, realaddr.Port, "ethereum discovery")
+				srv.loopWG.Done()
+			}()
 		}
 	}
 	srv.localnode.SetFallbackUDP(realaddr.Port)