Skip to content

G
Geth-Modification
Unverified Commit ba99e192 authored by Kosuke Taniguchi's avatar Kosuke Taniguchi Committed by GitHub
Browse files
Options

internal/ethapi: add comment explaining return of nil instead of error (#25097) 

Co-authored-by: 's avatarFelix Lange <fjl@twurst.com>
parent 67454df0
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
internal/ethapi/api.go
View file @ ba99e192
...@@ -1581,6 +1581,8 @@ func (s *PublicTransactionPoolAPI) GetRawTransactionByHash(ctx context.Context, ...@@ -1581,6 +1581,8 @@ func (s *PublicTransactionPoolAPI) GetRawTransactionByHash(ctx context.Context,
func (s *PublicTransactionPoolAPI) GetTransactionReceipt(ctx context.Context, hash common.Hash) (map[string]interface{}, error) { func (s *PublicTransactionPoolAPI) GetTransactionReceipt(ctx context.Context, hash common.Hash) (map[string]interface{}, error) {
tx, blockHash, blockNumber, index, err := s.b.GetTransaction(ctx, hash) tx, blockHash, blockNumber, index, err := s.b.GetTransaction(ctx, hash)
if err != nil { if err != nil {
// When the transaction doesn't exist, the RPC method should return JSON null
// as per specification.
return nil, nil return nil, nil
} }
receipts, err := s.b.GetReceipts(ctx, blockHash) receipts, err := s.b.GetReceipts(ctx, blockHash)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment