Commit 7a59a938 authored by Evangelos Pappas's avatar Evangelos Pappas Committed by Péter Szilágyi

cmd/utils: handle git commit a bit safer for user specified strings (#15790)

* cmd/utils/flags.go: Applying a String len guard for the gitCommit param of the NewApp()

* cmd/utils: remove redundant clause in if condition
parent 762f3a48
...@@ -96,7 +96,7 @@ func NewApp(gitCommit, usage string) *cli.App { ...@@ -96,7 +96,7 @@ func NewApp(gitCommit, usage string) *cli.App {
//app.Authors = nil //app.Authors = nil
app.Email = "" app.Email = ""
app.Version = params.Version app.Version = params.Version
if gitCommit != "" { if len(gitCommit) >= 8 {
app.Version += "-" + gitCommit[:8] app.Version += "-" + gitCommit[:8]
} }
app.Usage = usage app.Usage = usage
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment