Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
G
Geth-Modification
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
张蕾
Geth-Modification
Commits
750115ff
Unverified
Commit
750115ff
authored
3 years ago
by
meowsbits
Committed by
GitHub
3 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
p2p/nat: skip TestUPNP in non-CI environments if discover fails (#22877)
Fixes #21476
parent
51b32cc7
master
v1.10.12
v1.10.12-modified
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
1 deletion
+6
-1
natupnp_test.go
p2p/nat/natupnp_test.go
+6
-1
No files found.
p2p/nat/natupnp_test.go
View file @
750115ff
...
...
@@ -21,6 +21,7 @@ import (
"io"
"net"
"net/http"
"os"
"runtime"
"strings"
"testing"
...
...
@@ -162,7 +163,11 @@ func TestUPNP_DDWRT(t *testing.T) {
// Attempt to discover the fake device.
discovered
:=
discoverUPnP
()
if
discovered
==
nil
{
t
.
Fatalf
(
"not discovered"
)
if
os
.
Getenv
(
"CI"
)
!=
""
{
t
.
Fatalf
(
"not discovered"
)
}
else
{
t
.
Skipf
(
"UPnP not discovered (known issue, see https://github.com/ethereum/go-ethereum/issues/21476)"
)
}
}
upnp
,
_
:=
discovered
.
(
*
upnp
)
if
upnp
.
service
!=
"IGDv1-IP1"
{
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment