Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
G
Geth-Modification
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
张蕾
Geth-Modification
Commits
61a59763
Commit
61a59763
authored
6 years ago
by
Wenbiao Zheng
Committed by
Guillaume Ballet
6 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
accounts: remove deadcode isSigned (#16990)
parent
88c42ab4
master
v1.10.12
v1.10.12-modified
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
26 deletions
+0
-26
numbers.go
accounts/abi/numbers.go
+0
-15
numbers_test.go
accounts/abi/numbers_test.go
+0
-11
No files found.
accounts/abi/numbers.go
View file @
61a59763
...
...
@@ -31,29 +31,14 @@ var (
uint16T
=
reflect
.
TypeOf
(
uint16
(
0
))
uint32T
=
reflect
.
TypeOf
(
uint32
(
0
))
uint64T
=
reflect
.
TypeOf
(
uint64
(
0
))
intT
=
reflect
.
TypeOf
(
int
(
0
))
int8T
=
reflect
.
TypeOf
(
int8
(
0
))
int16T
=
reflect
.
TypeOf
(
int16
(
0
))
int32T
=
reflect
.
TypeOf
(
int32
(
0
))
int64T
=
reflect
.
TypeOf
(
int64
(
0
))
addressT
=
reflect
.
TypeOf
(
common
.
Address
{})
intTS
=
reflect
.
TypeOf
([]
int
(
nil
))
int8TS
=
reflect
.
TypeOf
([]
int8
(
nil
))
int16TS
=
reflect
.
TypeOf
([]
int16
(
nil
))
int32TS
=
reflect
.
TypeOf
([]
int32
(
nil
))
int64TS
=
reflect
.
TypeOf
([]
int64
(
nil
))
)
// U256 converts a big Int into a 256bit EVM number.
func
U256
(
n
*
big
.
Int
)
[]
byte
{
return
math
.
PaddedBigBytes
(
math
.
U256
(
n
),
32
)
}
// checks whether the given reflect value is signed. This also works for slices with a number type
func
isSigned
(
v
reflect
.
Value
)
bool
{
switch
v
.
Type
()
{
case
intTS
,
int8TS
,
int16TS
,
int32TS
,
int64TS
,
intT
,
int8T
,
int16T
,
int32T
,
int64T
:
return
true
}
return
false
}
This diff is collapsed.
Click to expand it.
accounts/abi/numbers_test.go
View file @
61a59763
...
...
@@ -19,7 +19,6 @@ package abi
import
(
"bytes"
"math/big"
"reflect"
"testing"
)
...
...
@@ -32,13 +31,3 @@ func TestNumberTypes(t *testing.T) {
t
.
Errorf
(
"expected %x got %x"
,
ubytes
,
unsigned
)
}
}
func
TestSigned
(
t
*
testing
.
T
)
{
if
isSigned
(
reflect
.
ValueOf
(
uint
(
10
)))
{
t
.
Error
(
"signed"
)
}
if
!
isSigned
(
reflect
.
ValueOf
(
int
(
10
)))
{
t
.
Error
(
"not signed"
)
}
}
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment