Unverified Commit 5c2a7ce2 authored by rene's avatar rene Committed by GitHub

node: rename startNetworking to openEndpoints (#22105)

parent 47820ef7
...@@ -159,12 +159,13 @@ func (n *Node) Start() error { ...@@ -159,12 +159,13 @@ func (n *Node) Start() error {
return ErrNodeStopped return ErrNodeStopped
} }
n.state = runningState n.state = runningState
err := n.startNetworking() // open networking and RPC endpoints
err := n.openEndpoints()
lifecycles := make([]Lifecycle, len(n.lifecycles)) lifecycles := make([]Lifecycle, len(n.lifecycles))
copy(lifecycles, n.lifecycles) copy(lifecycles, n.lifecycles)
n.lock.Unlock() n.lock.Unlock()
// Check if networking startup failed. // Check if endpoint startup failed.
if err != nil { if err != nil {
n.doClose(nil) n.doClose(nil)
return err return err
...@@ -247,12 +248,14 @@ func (n *Node) doClose(errs []error) error { ...@@ -247,12 +248,14 @@ func (n *Node) doClose(errs []error) error {
} }
} }
// startNetworking starts all network endpoints. // openEndpoints starts all network and RPC endpoints.
func (n *Node) startNetworking() error { func (n *Node) openEndpoints() error {
// start networking endpoints
n.log.Info("Starting peer-to-peer node", "instance", n.server.Name) n.log.Info("Starting peer-to-peer node", "instance", n.server.Name)
if err := n.server.Start(); err != nil { if err := n.server.Start(); err != nil {
return convertFileLockError(err) return convertFileLockError(err)
} }
// start RPC endpoints
err := n.startRPC() err := n.startRPC()
if err != nil { if err != nil {
n.stopRPC() n.stopRPC()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment