Skip to content

G
Geth-Modification
Commit 57c911c3 authored by Bas van Kervel's avatar Bas van Kervel
Browse files
Options

bugfix in startRPC error handling

parent 4ee7f6fc
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
rpc/api/admin.go
View file @ 57c911c3
...@@ -217,7 +217,6 @@ func (self *adminApi) SetSolc(req *shared.Request) (interface{}, error) { ...@@ -217,7 +217,6 @@ func (self *adminApi) SetSolc(req *shared.Request) (interface{}, error) {
} }
func (self *adminApi) StartRPC(req *shared.Request) (interface{}, error) { func (self *adminApi) StartRPC(req *shared.Request) (interface{}, error) {
var err error
args := new(StartRPCArgs) args := new(StartRPCArgs)
if err := self.coder.Decode(req.Params, &args); err != nil { if err := self.coder.Decode(req.Params, &args); err != nil {
return nil, shared.NewDecodeParamError(err.Error()) return nil, shared.NewDecodeParamError(err.Error())
...@@ -229,14 +228,15 @@ func (self *adminApi) StartRPC(req *shared.Request) (interface{}, error) { ...@@ -229,14 +228,15 @@ func (self *adminApi) StartRPC(req *shared.Request) (interface{}, error) {
CorsDomain: args.CorsDomain, CorsDomain: args.CorsDomain,
} }
if apis, err := ParseApiString(args.Apis, self.codec, self.xeth, self.ethereum); err == nil { apis, err := ParseApiString(args.Apis, self.codec, self.xeth, self.ethereum)
err = comms.StartHttp(cfg, self.codec, Merge(apis...)) if err != nil {
return false, err
} }
err = comms.StartHttp(cfg, self.codec, Merge(apis...))
if err == nil { if err == nil {
return true, nil return true, nil
} }
return false, err return false, err
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment