Add comment explaining why iota is not used.

357b4bc1 · Sam Boyer · 5adbd399 · 357b4bc1 · 357b4bc1
Commit 357b4bc1 authored Feb 18, 2014 by Sam Boyer
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

messaging.go ethwire/messaging.go +3 -0

peer.go peer.go +3 -0

No files found.
--- a/ethwire/messaging.go
+++ b/ethwire/messaging.go
@@ -19,6 +19,9 @@ var MagicToken = []byte{34, 64, 8, 145}
 type MsgType byte

 const (
+	// Values are given explicitly instead of by iota because these values are
+	// defined by the wire protocol spec; it is easier for humans to ensure
+	// correctness when values are explicit.
 	MsgHandshakeTy  = 0x00
 	MsgDiscTy       = 0x01
 	MsgPingTy       = 0x02

--- a/peer.go
+++ b/peer.go
@@ -23,6 +23,9 @@ const (
 type DiscReason byte

 const (
+	// Values are given explicitly instead of by iota because these values are
+	// defined by the wire protocol spec; it is easier for humans to ensure
+	// correctness when values are explicit.
 	DiscReRequested  = 0x00
 	DiscReTcpSysErr  = 0x01
 	DiscBadProto     = 0x02