Skip to content

G
Geth-Modification
Commit 21649100 authored by Felix Lange's avatar Felix Lange
Browse files
Options

p2p: verify protocol handshake node ID

parent 7d39fd66
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 0 deletions
p2p/handshake.go
View file @ 21649100
...@@ -89,6 +89,9 @@ func setupInboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake) ( ...@@ -89,6 +89,9 @@ func setupInboundConn(fd net.Conn, prv *ecdsa.PrivateKey, our *protoHandshake) (
if err != nil { if err != nil {
return nil, err return nil, err
} }
if rhs.ID != secrets.RemoteID {
return nil, errors.New("node ID in protocol handshake does not match encryption handshake")
}
// TODO: validate that handshake node ID matches // TODO: validate that handshake node ID matches
if err := writeProtocolHandshake(rw, our); err != nil { if err := writeProtocolHandshake(rw, our); err != nil {
return nil, fmt.Errorf("protocol write error: %v", err) return nil, fmt.Errorf("protocol write error: %v", err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment