Merge pull request #982 from tgerring/issue962

Check for error on DB fetch of tx

Merge pull request #982 from tgerring/issue962
Check for error on DB fetch of tx
007bced2 · Jeffrey Wilcke · 6bc8dec7 · 12f82ab2 · 007bced2
Commit 007bced2 authored May 14, 2015 by Jeffrey Wilcke
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

xeth.go xeth/xeth.go +5 -1

No files found.
--- a/xeth/xeth.go
+++ b/xeth/xeth.go
@@ -318,7 +318,11 @@ func (self *XEth) EthTransactionByHash(hash string) (tx *types.Transaction, blha
 		Index      uint64
 	}
-	v, _ := self.backend.ExtraDb().Get(append(common.FromHex(hash), 0x0001))
+	v, dberr := self.backend.ExtraDb().Get(append(common.FromHex(hash), 0x0001))
+	// TODO check specifically for ErrNotFound
+	if dberr != nil {
+		return
+	}
 	r := bytes.NewReader(v)
 	err := rlp.Decode(r, &txExtra)
 	if err == nil {