• Boqin Qin's avatar
    all: fix a bunch of inconsequential goroutine leaks (#20667) · be6078ad
    Boqin Qin authored
    The leaks were mostly in unit tests, and could all be resolved by
    adding suitably-sized channel buffers or by restructuring the test
    to not send on a channel after an error has occurred.
    
    There is an unavoidable goroutine leak in Console.Interactive: when
    we receive a signal, the line reader cannot be unblocked and will get
    stuck. This leak is now documented and I've tried to make it slightly 
    less bad by adding a one-element buffer to the output channels of
    the line-reading loop. Should the reader eventually awake from its
    blocked state (i.e. when stdin is closed), at least it won't get stuck
    trying to send to the interpreter loop which has quit long ago.
    Co-authored-by: 's avatarFelix Lange <fjl@twurst.com>
    be6078ad
subscription_test.go 6.26 KB