• Felix Lange's avatar
    p2p/discover: move bond logic from table to transport (#17048) · c73b654f
    Felix Lange authored
    * p2p/discover: move bond logic from table to transport
    
    This commit moves node endpoint verification (bonding) from the table to
    the UDP transport implementation. Previously, adding a node to the table
    entailed pinging the node if needed. With this change, the ping-back
    logic is embedded in the packet handler at a lower level.
    
    It is easy to verify that the basic protocol is unchanged: we still
    require a valid pong reply from the node before findnode is accepted.
    
    The node database tracked the time of last ping sent to the node and
    time of last valid pong received from the node. Node endpoints are
    considered verified when a valid pong is received and the time of last
    pong was called 'bond time'. The time of last ping sent was unused. In
    this commit, the last ping database entry is repurposed to mean last
    ping _received_. This entry is now used to track whether the node needs
    to be pinged back.
    
    The other big change is how nodes are added to the table. We used to add
    nodes in Table.bond, which ran when a remote node pinged us or when we
    encountered the node in a neighbors reply. The transport now adds to the
    table directly after the endpoint is verified through ping. To ensure
    that the Table can't be filled just by pinging the node repeatedly, we
    retain the isInitDone check. During init, only nodes from neighbors
    replies are added.
    
    * p2p/discover: reduce findnode failure counter on success
    
    * p2p/discover: remove unused parameter of loadSeedNodes
    
    * p2p/discover: improve ping-back check and comments
    
    * p2p/discover: add neighbors reply nodes always, not just during init
    c73b654f
udp_test.go 20 KB