• Zachinquarantine's avatar
    cmd/geth, cmd/utils: remove legacy rpc flags (#23358) · 9a0df80b
    Zachinquarantine authored
    * remove rpc flags
    
    * remove legacy rpc flags
    
    * remove legacy rpc flags
    
    * remove legacy rpc commands
    
    * (hopefully) fix most of the build errors
    
    * fix build errors
    
    https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/530318686
    
    * cmd/utils: fix syntax error
    
    * empty commit to unbreak travis ci
    
    * fix syntax error
    
    * syntax fixes
    
    * syntax fixes
    
    * fix
    
    fixes "cmd/geth/usage.go:234:7: expected '(', found init (typecheck)"
    
    * fix
    
    * various fixes in usage.go
    
    * various fixes in flags.go
    
    * adds extra space
    
    reverts the spacing to how it was before I resolved the merge conflict
    
    * more fixes in usage.go
    
    * fix
    
    fix for cmd/geth/usage.go:243:17: expected operand, found ':=' (typecheck) in travis
    
    * Update cmd/utils/flags.go
    Co-authored-by: 's avatarMartin Holst Swende <martin@swende.se>
    
    * fix error
    
     fixes these errors:
    cmd/utils/flags_legacy.go:21:2: "strings" imported but not used (typecheck)
    
    	"strings"
    
    	^
    
    cmd/utils/flags_legacy.go:24:2: "github.com/ethereum/go-ethereum/node" imported but not used (typecheck)
    
    	"github.com/ethereum/go-ethereum/node"
    
    	^
    
    * goimports
    Co-authored-by: 's avatarMartin Holst Swende <martin@swende.se>
    9a0df80b
flags_legacy.go 2.08 KB
// Copyright 2020 The go-ethereum Authors
// This file is part of go-ethereum.
//
// go-ethereum is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// go-ethereum is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with go-ethereum. If not, see <http://www.gnu.org/licenses/>.

package utils

import (
	"fmt"

	"github.com/ethereum/go-ethereum/eth/ethconfig"
	"gopkg.in/urfave/cli.v1"
)

var ShowDeprecated = cli.Command{
	Action:      showDeprecated,
	Name:        "show-deprecated-flags",
	Usage:       "Show flags that have been deprecated",
	ArgsUsage:   " ",
	Category:    "MISCELLANEOUS COMMANDS",
	Description: "Show flags that have been deprecated and will soon be removed",
}

var DeprecatedFlags = []cli.Flag{
	LegacyMinerGasTargetFlag,
	NoUSBFlag,
}

var (
	// (Deprecated May 2020, shown in aliased flags section)
	NoUSBFlag = cli.BoolFlag{
		Name:  "nousb",
		Usage: "Disables monitoring for and managing USB hardware wallets (deprecated)",
	}
	// (Deprecated July 2021, shown in aliased flags section)
	LegacyMinerGasTargetFlag = cli.Uint64Flag{
		Name:  "miner.gastarget",
		Usage: "Target gas floor for mined blocks (deprecated)",
		Value: ethconfig.Defaults.Miner.GasFloor,
	}
)

// showDeprecated displays deprecated flags that will be soon removed from the codebase.
func showDeprecated(*cli.Context) {
	fmt.Println("--------------------------------------------------------------------")
	fmt.Println("The following flags are deprecated and will be removed in the future!")
	fmt.Println("--------------------------------------------------------------------")
	fmt.Println()
	for _, flag := range DeprecatedFlags {
		fmt.Println(flag.String())
	}
	fmt.Println()
}