• Roberto Bayardo's avatar
    core, core/types: plain Message struct (#25977) · 67ac5f0a
    Roberto Bayardo authored
    Here, the core.Message interface turns into a plain struct and
    types.Message gets removed.
    
    This is a breaking change to packages core and core/types. While we do
    not promise API stability for package core, we do for core/types. An
    exception can be made for types.Message, since it doesn't have any
    purpose apart from invoking the state transition in package core.
    types.Message was also marked deprecated by the same commit it
    got added in, 4dca5d4d (November 2016).
    
    The core.Message interface was added in December 2014, in commit
    db494170, for the purpose of 'testing' state transitions. It's the
    same change that made transaction struct fields private. Before that,
    the state transition used *types.Transaction directly.
    
    Over time, multiple implementations of the interface accrued across
    different packages, since constructing a Message is required whenever
    one wants to invoke the state transition. These implementations all
    looked very similar, a struct with private fields exposing the fields
    as accessor methods.
    
    By changing Message into a struct with public fields we can remove all
    these useless interface implementations. It will also hopefully
    simplify future changes to the type with less updates to apply across
    all of go-ethereum when a field is added to Message.
    
    ---------
    Co-authored-by: 's avatarFelix Lange <fjl@twurst.com>
    67ac5f0a
evm.go 4.27 KB