• Felix Lange's avatar
    p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) · f0c6f921
    Felix Lange authored
    This change resolves multiple issues around handling of endpoint proofs.
    The proof is now done separately for each IP and completing the proof
    requires a matching ping hash.
    
    Also remove waitping because it's equivalent to sleep. waitping was
    slightly more efficient, but that may cause issues with findnode if
    packets are reordered and the remote end sees findnode before pong.
    
    Logging of received packets was hitherto done after handling the packet,
    which meant that sent replies were logged before the packet that
    generated them. This change splits up packet handling into 'preverify'
    and 'handle'. The error from 'preverify' is logged, but 'handle' happens
    after the message is logged. This fixes the order. Packet logs now
    contain the node ID.
    f0c6f921
node.go 2.7 KB