• zelig's avatar
    blockpool stability fixes: · 3d57e377
    zelig authored
    - follow up locks and fix them
    - chainManager: call SetQueued for parentErr future blocks, uncomment TD checks, unskip test
    - make ErrIncorrectTD non-fatal to be forgiving to genuine mistaken nodes (temp) but demote them to guard against stuck best peers.
    - add purging to bounded nodeCache (config nodeCacheSize)
    - use nodeCache when creating blockpool entries and let non-best peers add blocks (performance boost)
    - minor error in addError
    - reduce idleBestPeerTimeout to 1 minute
    - correct status counts and unskip status passing status test
    - glogified logging
    3d57e377
errors_test.go 889 Bytes
package errs

import (
	"fmt"
	"testing"

	"github.com/ethereum/go-ethereum/logger"
)

func testErrors() *Errors {
	return &Errors{
		Package: "TEST",
		Errors: map[int]string{
			0: "zero",
			1: "one",
		},
		Level: func(i int) (l logger.LogLevel) {
			if i == 0 {
				l = logger.ErrorLevel
			} else {
				l = logger.WarnLevel
			}
			return
		},
	}
}

func TestErrorMessage(t *testing.T) {
	err := testErrors().New(0, "zero detail %v", "available")
	message := fmt.Sprintf("%v", err)
	exp := "[TEST] ERROR: zero: zero detail available"
	if message != exp {
		t.Errorf("error message incorrect. expected %v, got %v", exp, message)
	}
}

func TestErrorSeverity(t *testing.T) {
	err0 := testErrors().New(0, "zero detail")
	if !err0.Fatal() {
		t.Errorf("error should be fatal")
	}
	err1 := testErrors().New(1, "one detail")
	if err1.Fatal() {
		t.Errorf("error should not be fatal")
	}
}