decode_test.go 32.5 KB
Newer Older
1
// Copyright 2014 The go-ethereum Authors
2
// This file is part of the go-ethereum library.
3
//
4
// The go-ethereum library is free software: you can redistribute it and/or modify
5 6 7 8
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
9
// The go-ethereum library is distributed in the hope that it will be useful,
10
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 13 14
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
15
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
16

17 18 19 20 21
package rlp

import (
	"bytes"
	"encoding/hex"
22
	"errors"
23 24 25 26
	"fmt"
	"io"
	"math/big"
	"reflect"
Felix Lange's avatar
Felix Lange committed
27
	"strings"
28
	"testing"
29 30

	"github.com/ethereum/go-ethereum/common/math"
31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
)

func TestStreamKind(t *testing.T) {
	tests := []struct {
		input    string
		wantKind Kind
		wantLen  uint64
	}{
		{"00", Byte, 0},
		{"01", Byte, 0},
		{"7F", Byte, 0},
		{"80", String, 0},
		{"B7", String, 55},
		{"B90400", String, 1024},
		{"BFFFFFFFFFFFFFFFFF", String, ^uint64(0)},
		{"C0", List, 0},
		{"C8", List, 8},
		{"F7", List, 55},
		{"F90400", List, 1024},
		{"FFFFFFFFFFFFFFFFFF", List, ^uint64(0)},
	}

	for i, test := range tests {
54 55
		// using plainReader to inhibit input limit errors.
		s := NewStream(newPlainReader(unhex(test.input)), 0)
56 57
		kind, len, err := s.Kind()
		if err != nil {
58
			t.Errorf("test %d: Kind returned error: %v", i, err)
59 60 61 62 63 64 65 66 67 68 69
			continue
		}
		if kind != test.wantKind {
			t.Errorf("test %d: kind mismatch: got %d, want %d", i, kind, test.wantKind)
		}
		if len != test.wantLen {
			t.Errorf("test %d: len mismatch: got %d, want %d", i, len, test.wantLen)
		}
	}
}

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87
func TestNewListStream(t *testing.T) {
	ls := NewListStream(bytes.NewReader(unhex("0101010101")), 3)
	if k, size, err := ls.Kind(); k != List || size != 3 || err != nil {
		t.Errorf("Kind() returned (%v, %d, %v), expected (List, 3, nil)", k, size, err)
	}
	if size, err := ls.List(); size != 3 || err != nil {
		t.Errorf("List() returned (%d, %v), expected (3, nil)", size, err)
	}
	for i := 0; i < 3; i++ {
		if val, err := ls.Uint(); val != 1 || err != nil {
			t.Errorf("Uint() returned (%d, %v), expected (1, nil)", val, err)
		}
	}
	if err := ls.ListEnd(); err != nil {
		t.Errorf("ListEnd() returned %v, expected (3, nil)", err)
	}
}

88
func TestStreamErrors(t *testing.T) {
89 90 91 92 93 94 95 96 97
	withoutInputLimit := func(b []byte) *Stream {
		return NewStream(newPlainReader(b), 0)
	}
	withCustomInputLimit := func(limit uint64) func([]byte) *Stream {
		return func(b []byte) *Stream {
			return NewStream(bytes.NewReader(b), limit)
		}
	}

98 99 100 101
	type calls []string
	tests := []struct {
		string
		calls
102
		newStream func([]byte) *Stream // uses bytes.Reader if nil
103
		error     error
104
	}{
105 106 107 108 109 110 111 112 113 114 115
		{"C0", calls{"Bytes"}, nil, ErrExpectedString},
		{"C0", calls{"Uint"}, nil, ErrExpectedString},
		{"89000000000000000001", calls{"Uint"}, nil, errUintOverflow},
		{"00", calls{"List"}, nil, ErrExpectedList},
		{"80", calls{"List"}, nil, ErrExpectedList},
		{"C0", calls{"List", "Uint"}, nil, EOL},
		{"C8C9010101010101010101", calls{"List", "Kind"}, nil, ErrElemTooLarge},
		{"C3C2010201", calls{"List", "List", "Uint", "Uint", "ListEnd", "Uint"}, nil, EOL},
		{"00", calls{"ListEnd"}, nil, errNotInList},
		{"C401020304", calls{"List", "Uint", "ListEnd"}, nil, errNotAtEOL},

116
		// Non-canonical integers (e.g. leading zero bytes).
117 118
		{"00", calls{"Uint"}, nil, ErrCanonInt},
		{"820002", calls{"Uint"}, nil, ErrCanonInt},
119
		{"8133", calls{"Uint"}, nil, ErrCanonSize},
120 121
		{"817F", calls{"Uint"}, nil, ErrCanonSize},
		{"8180", calls{"Uint"}, nil, nil},
122

123 124 125
		// Non-valid boolean
		{"02", calls{"Bool"}, nil, errors.New("rlp: invalid boolean value: 2")},

126 127
		// Size tags must use the smallest possible encoding.
		// Leading zero bytes in the size tag are also rejected.
128 129
		{"8100", calls{"Uint"}, nil, ErrCanonSize},
		{"8100", calls{"Bytes"}, nil, ErrCanonSize},
130 131 132
		{"8101", calls{"Bytes"}, nil, ErrCanonSize},
		{"817F", calls{"Bytes"}, nil, ErrCanonSize},
		{"8180", calls{"Bytes"}, nil, nil},
133 134 135 136 137 138 139 140 141
		{"B800", calls{"Kind"}, withoutInputLimit, ErrCanonSize},
		{"B90000", calls{"Kind"}, withoutInputLimit, ErrCanonSize},
		{"B90055", calls{"Kind"}, withoutInputLimit, ErrCanonSize},
		{"BA0002FFFF", calls{"Bytes"}, withoutInputLimit, ErrCanonSize},
		{"F800", calls{"Kind"}, withoutInputLimit, ErrCanonSize},
		{"F90000", calls{"Kind"}, withoutInputLimit, ErrCanonSize},
		{"F90055", calls{"Kind"}, withoutInputLimit, ErrCanonSize},
		{"FA0002FFFF", calls{"List"}, withoutInputLimit, ErrCanonSize},

142 143 144 145
		// Expected EOF
		{"", calls{"Kind"}, nil, io.EOF},
		{"", calls{"Uint"}, nil, io.EOF},
		{"", calls{"List"}, nil, io.EOF},
146
		{"8180", calls{"Uint", "Uint"}, nil, io.EOF},
147 148
		{"C0", calls{"List", "ListEnd", "List"}, nil, io.EOF},

149
		{"", calls{"List"}, withoutInputLimit, io.EOF},
150
		{"8180", calls{"Uint", "Uint"}, withoutInputLimit, io.EOF},
151 152
		{"C0", calls{"List", "ListEnd", "List"}, withoutInputLimit, io.EOF},

153 154 155 156 157 158 159
		// Input limit errors.
		{"81", calls{"Bytes"}, nil, ErrValueTooLarge},
		{"81", calls{"Uint"}, nil, ErrValueTooLarge},
		{"81", calls{"Raw"}, nil, ErrValueTooLarge},
		{"BFFFFFFFFFFFFFFFFFFF", calls{"Bytes"}, nil, ErrValueTooLarge},
		{"C801", calls{"List"}, nil, ErrValueTooLarge},

160 161 162
		// Test for list element size check overflow.
		{"CD04040404FFFFFFFFFFFFFFFFFF0303", calls{"List", "Uint", "Uint", "Uint", "Uint", "List"}, nil, ErrElemTooLarge},

163 164 165 166
		// Test for input limit overflow. Since we are counting the limit
		// down toward zero in Stream.remaining, reading too far can overflow
		// remaining to a large value, effectively disabling the limit.
		{"C40102030401", calls{"Raw", "Uint"}, withCustomInputLimit(5), io.EOF},
167
		{"C4010203048180", calls{"Raw", "Uint"}, withCustomInputLimit(6), ErrValueTooLarge},
168 169 170

		// Check that the same calls are fine without a limit.
		{"C40102030401", calls{"Raw", "Uint"}, withoutInputLimit, nil},
171
		{"C4010203048180", calls{"Raw", "Uint"}, withoutInputLimit, nil},
172 173 174 175 176 177 178

		// Unexpected EOF. This only happens when there is
		// no input limit, so the reader needs to be 'dumbed down'.
		{"81", calls{"Bytes"}, withoutInputLimit, io.ErrUnexpectedEOF},
		{"81", calls{"Uint"}, withoutInputLimit, io.ErrUnexpectedEOF},
		{"BFFFFFFFFFFFFFFF", calls{"Bytes"}, withoutInputLimit, io.ErrUnexpectedEOF},
		{"C801", calls{"List", "Uint", "Uint"}, withoutInputLimit, io.ErrUnexpectedEOF},
179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194

		// This test verifies that the input position is advanced
		// correctly when calling Bytes for empty strings. Kind can be called
		// any number of times in between and doesn't advance.
		{"C3808080", calls{
			"List",  // enter the list
			"Bytes", // past first element

			"Kind", "Kind", "Kind", // this shouldn't advance

			"Bytes", // past second element

			"Kind", "Kind", // can't hurt to try

			"Bytes", // past final element
			"Bytes", // this one should fail
195
		}, nil, EOL},
196 197 198 199
	}

testfor:
	for i, test := range tests {
200 201 202 203
		if test.newStream == nil {
			test.newStream = func(b []byte) *Stream { return NewStream(bytes.NewReader(b), 0) }
		}
		s := test.newStream(unhex(test.string))
204 205 206 207 208 209 210 211 212
		rs := reflect.ValueOf(s)
		for j, call := range test.calls {
			fval := rs.MethodByName(call)
			ret := fval.Call(nil)
			err := "<nil>"
			if lastret := ret[len(ret)-1].Interface(); lastret != nil {
				err = lastret.(error).Error()
			}
			if j == len(test.calls)-1 {
213 214 215 216 217
				want := "<nil>"
				if test.error != nil {
					want = test.error.Error()
				}
				if err != want {
218
					t.Log(test)
219
					t.Errorf("test %d: last call (%s) error mismatch\ngot:  %s\nwant: %s",
220 221 222
						i, call, err, test.error)
				}
			} else if err != "<nil>" {
223
				t.Log(test)
224 225 226 227 228 229 230 231
				t.Errorf("test %d: call %d (%s) unexpected error: %q", i, j, call, err)
				continue testfor
			}
		}
	}
}

func TestStreamList(t *testing.T) {
232
	s := NewStream(bytes.NewReader(unhex("C80102030405060708")), 0)
233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259

	len, err := s.List()
	if err != nil {
		t.Fatalf("List error: %v", err)
	}
	if len != 8 {
		t.Fatalf("List returned invalid length, got %d, want 8", len)
	}

	for i := uint64(1); i <= 8; i++ {
		v, err := s.Uint()
		if err != nil {
			t.Fatalf("Uint error: %v", err)
		}
		if i != v {
			t.Errorf("Uint returned wrong value, got %d, want %d", v, i)
		}
	}

	if _, err := s.Uint(); err != EOL {
		t.Errorf("Uint error mismatch, got %v, want %v", err, EOL)
	}
	if err = s.ListEnd(); err != nil {
		t.Fatalf("ListEnd error: %v", err)
	}
}

Felix Lange's avatar
Felix Lange committed
260
func TestStreamRaw(t *testing.T) {
261 262 263 264 265 266 267 268 269 270 271 272
	tests := []struct {
		input  string
		output string
	}{
		{
			"C58401010101",
			"8401010101",
		},
		{
			"F842B84001010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101",
			"B84001010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101",
		},
Felix Lange's avatar
Felix Lange committed
273
	}
274 275 276 277 278 279 280 281 282 283 284 285
	for i, tt := range tests {
		s := NewStream(bytes.NewReader(unhex(tt.input)), 0)
		s.List()

		want := unhex(tt.output)
		raw, err := s.Raw()
		if err != nil {
			t.Fatal(err)
		}
		if !bytes.Equal(want, raw) {
			t.Errorf("test %d: raw mismatch: got %x, want %x", i, raw, want)
		}
Felix Lange's avatar
Felix Lange committed
286 287 288
	}
}

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
func TestDecodeErrors(t *testing.T) {
	r := bytes.NewReader(nil)

	if err := Decode(r, nil); err != errDecodeIntoNil {
		t.Errorf("Decode(r, nil) error mismatch, got %q, want %q", err, errDecodeIntoNil)
	}

	var nilptr *struct{}
	if err := Decode(r, nilptr); err != errDecodeIntoNil {
		t.Errorf("Decode(r, nilptr) error mismatch, got %q, want %q", err, errDecodeIntoNil)
	}

	if err := Decode(r, struct{}{}); err != errNoPointer {
		t.Errorf("Decode(r, struct{}{}) error mismatch, got %q, want %q", err, errNoPointer)
	}

	expectErr := "rlp: type chan bool is not RLP-serializable"
	if err := Decode(r, new(chan bool)); err == nil || err.Error() != expectErr {
		t.Errorf("Decode(r, new(chan bool)) error mismatch, got %q, want %q", err, expectErr)
	}

310
	if err := Decode(r, new(uint)); err != io.EOF {
311 312 313 314 315 316 317 318
		t.Errorf("Decode(r, new(int)) error mismatch, got %q, want %q", err, io.EOF)
	}
}

type decodeTest struct {
	input string
	ptr   interface{}
	value interface{}
319
	error string
320 321 322
}

type simplestruct struct {
323
	A uint
324 325 326 327
	B string
}

type recstruct struct {
328
	I     uint
329
	Child *recstruct `rlp:"nil"`
330 331
}

332 333 334 335 336
type bigIntStruct struct {
	I *big.Int
	B string
}

337 338 339 340
type invalidNilTag struct {
	X []byte `rlp:"nil"`
}

341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360
type invalidTail1 struct {
	A uint `rlp:"tail"`
	B string
}

type invalidTail2 struct {
	A uint
	B string `rlp:"tail"`
}

type tailRaw struct {
	A    uint
	Tail []RawValue `rlp:"tail"`
}

type tailUint struct {
	A    uint
	Tail []uint `rlp:"tail"`
}

361 362 363
type tailPrivateFields struct {
	A    uint
	Tail []uint `rlp:"tail"`
364
	x, y bool   //lint:ignore U1000 unused fields required for testing purposes.
365 366
}

367 368 369 370 371 372 373 374 375 376 377 378
type nilListUint struct {
	X *uint `rlp:"nilList"`
}

type nilStringSlice struct {
	X *[]uint `rlp:"nilString"`
}

type intField struct {
	X int
}

379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411
type optionalFields struct {
	A uint
	B uint `rlp:"optional"`
	C uint `rlp:"optional"`
}

type optionalAndTailField struct {
	A    uint
	B    uint   `rlp:"optional"`
	Tail []uint `rlp:"tail"`
}

type optionalBigIntField struct {
	A uint
	B *big.Int `rlp:"optional"`
}

type optionalPtrField struct {
	A uint
	B *[3]byte `rlp:"optional"`
}

type optionalPtrFieldNil struct {
	A uint
	B *[3]byte `rlp:"optional,nil"`
}

type ignoredField struct {
	A uint
	B uint `rlp:"-"`
	C uint
}

412
var (
413
	veryBigInt = new(big.Int).Add(
414 415 416
		big.NewInt(0).Lsh(big.NewInt(0xFFFFFFFFFFFFFF), 16),
		big.NewInt(0xFFFF),
	)
417
	veryVeryBigInt = new(big.Int).Exp(veryBigInt, big.NewInt(8), nil)
418 419 420
)

var decodeTests = []decodeTest{
421 422 423 424 425
	// booleans
	{input: "01", ptr: new(bool), value: true},
	{input: "80", ptr: new(bool), value: false},
	{input: "02", ptr: new(bool), error: "rlp: invalid boolean value: 2"},

426 427 428 429 430 431
	// integers
	{input: "05", ptr: new(uint32), value: uint32(5)},
	{input: "80", ptr: new(uint32), value: uint32(0)},
	{input: "820505", ptr: new(uint32), value: uint32(0x0505)},
	{input: "83050505", ptr: new(uint32), value: uint32(0x050505)},
	{input: "8405050505", ptr: new(uint32), value: uint32(0x05050505)},
432 433
	{input: "850505050505", ptr: new(uint32), error: "rlp: input string too long for uint32"},
	{input: "C0", ptr: new(uint32), error: "rlp: expected input string or byte for uint32"},
434
	{input: "00", ptr: new(uint32), error: "rlp: non-canonical integer (leading zero bytes) for uint32"},
435
	{input: "8105", ptr: new(uint32), error: "rlp: non-canonical size information for uint32"},
436 437
	{input: "820004", ptr: new(uint32), error: "rlp: non-canonical integer (leading zero bytes) for uint32"},
	{input: "B8020004", ptr: new(uint32), error: "rlp: non-canonical size information for uint32"},
438 439

	// slices
440 441
	{input: "C0", ptr: new([]uint), value: []uint{}},
	{input: "C80102030405060708", ptr: new([]uint), value: []uint{1, 2, 3, 4, 5, 6, 7, 8}},
442
	{input: "F8020004", ptr: new([]uint), error: "rlp: non-canonical size information for []uint"},
443 444

	// arrays
445
	{input: "C50102030405", ptr: new([5]uint), value: [5]uint{1, 2, 3, 4, 5}},
446 447
	{input: "C0", ptr: new([5]uint), error: "rlp: input list has too few elements for [5]uint"},
	{input: "C102", ptr: new([5]uint), error: "rlp: input list has too few elements for [5]uint"},
448
	{input: "C6010203040506", ptr: new([5]uint), error: "rlp: input list has too many elements for [5]uint"},
449
	{input: "F8020004", ptr: new([5]uint), error: "rlp: non-canonical size information for [5]uint"},
450

451 452 453 454
	// zero sized arrays
	{input: "C0", ptr: new([0]uint), value: [0]uint{}},
	{input: "C101", ptr: new([0]uint), error: "rlp: input list has too many elements for [0]uint"},

455 456 457 458
	// byte slices
	{input: "01", ptr: new([]byte), value: []byte{1}},
	{input: "80", ptr: new([]byte), value: []byte{}},
	{input: "8D6162636465666768696A6B6C6D", ptr: new([]byte), value: []byte("abcdefghijklm")},
459 460
	{input: "C0", ptr: new([]byte), error: "rlp: expected input string or byte for []uint8"},
	{input: "8105", ptr: new([]byte), error: "rlp: non-canonical size information for []uint8"},
461 462

	// byte arrays
463
	{input: "02", ptr: new([1]byte), value: [1]byte{2}},
464
	{input: "8180", ptr: new([1]byte), value: [1]byte{128}},
465
	{input: "850102030405", ptr: new([5]byte), value: [5]byte{1, 2, 3, 4, 5}},
466 467

	// byte array errors
468 469 470
	{input: "02", ptr: new([5]byte), error: "rlp: input string too short for [5]uint8"},
	{input: "80", ptr: new([5]byte), error: "rlp: input string too short for [5]uint8"},
	{input: "820000", ptr: new([5]byte), error: "rlp: input string too short for [5]uint8"},
471 472 473
	{input: "C0", ptr: new([5]byte), error: "rlp: expected input string or byte for [5]uint8"},
	{input: "C3010203", ptr: new([5]byte), error: "rlp: expected input string or byte for [5]uint8"},
	{input: "86010203040506", ptr: new([5]byte), error: "rlp: input string too long for [5]uint8"},
474
	{input: "8105", ptr: new([1]byte), error: "rlp: non-canonical size information for [1]uint8"},
475
	{input: "817F", ptr: new([1]byte), error: "rlp: non-canonical size information for [1]uint8"},
476 477 478

	// zero sized byte arrays
	{input: "80", ptr: new([0]byte), value: [0]byte{}},
479 480
	{input: "01", ptr: new([0]byte), error: "rlp: input string too long for [0]uint8"},
	{input: "8101", ptr: new([0]byte), error: "rlp: input string too long for [0]uint8"},
481 482 483 484

	// strings
	{input: "00", ptr: new(string), value: "\000"},
	{input: "8D6162636465666768696A6B6C6D", ptr: new(string), value: "abcdefghijklm"},
485
	{input: "C0", ptr: new(string), error: "rlp: expected input string or byte for string"},
486 487

	// big ints
488
	{input: "80", ptr: new(*big.Int), value: big.NewInt(0)},
489 490
	{input: "01", ptr: new(*big.Int), value: big.NewInt(1)},
	{input: "89FFFFFFFFFFFFFFFFFF", ptr: new(*big.Int), value: veryBigInt},
491
	{input: "B848FFFFFFFFFFFFFFFFF800000000000000001BFFFFFFFFFFFFFFFFC8000000000000000045FFFFFFFFFFFFFFFFC800000000000000001BFFFFFFFFFFFFFFFFF8000000000000000001", ptr: new(*big.Int), value: veryVeryBigInt},
492
	{input: "10", ptr: new(big.Int), value: *big.NewInt(16)}, // non-pointer also works
493
	{input: "C0", ptr: new(*big.Int), error: "rlp: expected input string or byte for *big.Int"},
494 495 496
	{input: "00", ptr: new(*big.Int), error: "rlp: non-canonical integer (leading zero bytes) for *big.Int"},
	{input: "820001", ptr: new(*big.Int), error: "rlp: non-canonical integer (leading zero bytes) for *big.Int"},
	{input: "8105", ptr: new(*big.Int), error: "rlp: non-canonical size information for *big.Int"},
497 498 499

	// structs
	{
500 501 502 503 504 505
		input: "C50583343434",
		ptr:   new(simplestruct),
		value: simplestruct{5, "444"},
	},
	{
		input: "C601C402C203C0",
506 507 508
		ptr:   new(recstruct),
		value: recstruct{1, &recstruct{2, &recstruct{3, nil}}},
	},
509 510 511 512 513 514 515
	{
		// This checks that empty big.Int works correctly in struct context. It's easy to
		// miss the update of s.kind for this case, so it needs its own test.
		input: "C58083343434",
		ptr:   new(bigIntStruct),
		value: bigIntStruct{new(big.Int), "444"},
	},
516

517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532
	// struct errors
	{
		input: "C0",
		ptr:   new(simplestruct),
		error: "rlp: too few elements for rlp.simplestruct",
	},
	{
		input: "C105",
		ptr:   new(simplestruct),
		error: "rlp: too few elements for rlp.simplestruct",
	},
	{
		input: "C7C50583343434C0",
		ptr:   new([]*simplestruct),
		error: "rlp: too few elements for rlp.simplestruct, decoding into ([]*rlp.simplestruct)[1]",
	},
533 534 535 536 537
	{
		input: "83222222",
		ptr:   new(simplestruct),
		error: "rlp: expected input list for rlp.simplestruct",
	},
obscuren's avatar
obscuren committed
538 539 540 541 542 543 544 545 546 547
	{
		input: "C3010101",
		ptr:   new(simplestruct),
		error: "rlp: input list has too many elements for rlp.simplestruct",
	},
	{
		input: "C501C3C00000",
		ptr:   new(recstruct),
		error: "rlp: expected input string or byte for uint, decoding into (rlp.recstruct).Child.I",
	},
548
	{
549 550 551
		input: "C103",
		ptr:   new(intField),
		error: "rlp: type int is not RLP-serializable (struct field rlp.intField.X)",
552 553 554 555 556 557
	},
	{
		input: "C50102C20102",
		ptr:   new(tailUint),
		error: "rlp: expected input string or byte for uint, decoding into (rlp.tailUint).Tail[1]",
	},
558 559 560 561 562
	{
		input: "C0",
		ptr:   new(invalidNilTag),
		error: `rlp: invalid struct tag "nil" for rlp.invalidNilTag.X (field is not a pointer)`,
	},
563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579

	// struct tag "tail"
	{
		input: "C3010203",
		ptr:   new(tailRaw),
		value: tailRaw{A: 1, Tail: []RawValue{unhex("02"), unhex("03")}},
	},
	{
		input: "C20102",
		ptr:   new(tailRaw),
		value: tailRaw{A: 1, Tail: []RawValue{unhex("02")}},
	},
	{
		input: "C101",
		ptr:   new(tailRaw),
		value: tailRaw{A: 1, Tail: []RawValue{}},
	},
580 581 582 583 584
	{
		input: "C3010203",
		ptr:   new(tailPrivateFields),
		value: tailPrivateFields{A: 1, Tail: []uint{2, 3}},
	},
585 586 587 588 589 590 591 592 593 594
	{
		input: "C0",
		ptr:   new(invalidTail1),
		error: `rlp: invalid struct tag "tail" for rlp.invalidTail1.A (must be on last field)`,
	},
	{
		input: "C0",
		ptr:   new(invalidTail2),
		error: `rlp: invalid struct tag "tail" for rlp.invalidTail2.B (field type is not slice)`,
	},
obscuren's avatar
obscuren committed
595

596 597 598
	// struct tag "-"
	{
		input: "C20102",
599 600
		ptr:   new(ignoredField),
		value: ignoredField{A: 1, C: 2},
601 602
	},

603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639
	// struct tag "nilList"
	{
		input: "C180",
		ptr:   new(nilListUint),
		error: "rlp: wrong kind of empty value (got String, want List) for *uint, decoding into (rlp.nilListUint).X",
	},
	{
		input: "C1C0",
		ptr:   new(nilListUint),
		value: nilListUint{},
	},
	{
		input: "C103",
		ptr:   new(nilListUint),
		value: func() interface{} {
			v := uint(3)
			return nilListUint{X: &v}
		}(),
	},

	// struct tag "nilString"
	{
		input: "C1C0",
		ptr:   new(nilStringSlice),
		error: "rlp: wrong kind of empty value (got List, want String) for *[]uint, decoding into (rlp.nilStringSlice).X",
	},
	{
		input: "C180",
		ptr:   new(nilStringSlice),
		value: nilStringSlice{},
	},
	{
		input: "C2C103",
		ptr:   new(nilStringSlice),
		value: nilStringSlice{X: &[]uint{3}},
	},

640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743
	// struct tag "optional"
	{
		input: "C101",
		ptr:   new(optionalFields),
		value: optionalFields{1, 0, 0},
	},
	{
		input: "C20102",
		ptr:   new(optionalFields),
		value: optionalFields{1, 2, 0},
	},
	{
		input: "C3010203",
		ptr:   new(optionalFields),
		value: optionalFields{1, 2, 3},
	},
	{
		input: "C401020304",
		ptr:   new(optionalFields),
		error: "rlp: input list has too many elements for rlp.optionalFields",
	},
	{
		input: "C101",
		ptr:   new(optionalAndTailField),
		value: optionalAndTailField{A: 1},
	},
	{
		input: "C20102",
		ptr:   new(optionalAndTailField),
		value: optionalAndTailField{A: 1, B: 2, Tail: []uint{}},
	},
	{
		input: "C401020304",
		ptr:   new(optionalAndTailField),
		value: optionalAndTailField{A: 1, B: 2, Tail: []uint{3, 4}},
	},
	{
		input: "C101",
		ptr:   new(optionalBigIntField),
		value: optionalBigIntField{A: 1, B: nil},
	},
	{
		input: "C20102",
		ptr:   new(optionalBigIntField),
		value: optionalBigIntField{A: 1, B: big.NewInt(2)},
	},
	{
		input: "C101",
		ptr:   new(optionalPtrField),
		value: optionalPtrField{A: 1},
	},
	{
		input: "C20180", // not accepted because "optional" doesn't enable "nil"
		ptr:   new(optionalPtrField),
		error: "rlp: input string too short for [3]uint8, decoding into (rlp.optionalPtrField).B",
	},
	{
		input: "C20102",
		ptr:   new(optionalPtrField),
		error: "rlp: input string too short for [3]uint8, decoding into (rlp.optionalPtrField).B",
	},
	{
		input: "C50183010203",
		ptr:   new(optionalPtrField),
		value: optionalPtrField{A: 1, B: &[3]byte{1, 2, 3}},
	},
	{
		input: "C101",
		ptr:   new(optionalPtrFieldNil),
		value: optionalPtrFieldNil{A: 1},
	},
	{
		input: "C20180", // accepted because "nil" tag allows empty input
		ptr:   new(optionalPtrFieldNil),
		value: optionalPtrFieldNil{A: 1},
	},
	{
		input: "C20102",
		ptr:   new(optionalPtrFieldNil),
		error: "rlp: input string too short for [3]uint8, decoding into (rlp.optionalPtrFieldNil).B",
	},

	// struct tag "optional" field clearing
	{
		input: "C101",
		ptr:   &optionalFields{A: 9, B: 8, C: 7},
		value: optionalFields{A: 1, B: 0, C: 0},
	},
	{
		input: "C20102",
		ptr:   &optionalFields{A: 9, B: 8, C: 7},
		value: optionalFields{A: 1, B: 2, C: 0},
	},
	{
		input: "C20102",
		ptr:   &optionalAndTailField{A: 9, B: 8, Tail: []uint{7, 6, 5}},
		value: optionalAndTailField{A: 1, B: 2, Tail: []uint{}},
	},
	{
		input: "C101",
		ptr:   &optionalPtrField{A: 9, B: &[3]byte{8, 7, 6}},
		value: optionalPtrField{A: 1},
	},

Felix Lange's avatar
Felix Lange committed
744 745 746 747 748
	// RawValue
	{input: "01", ptr: new(RawValue), value: RawValue(unhex("01"))},
	{input: "82FFFF", ptr: new(RawValue), value: RawValue(unhex("82FFFF"))},
	{input: "C20102", ptr: new([]RawValue), value: []RawValue{unhex("01"), unhex("02")}},

749
	// pointers
750
	{input: "00", ptr: new(*[]byte), value: &[]byte{0}},
751 752
	{input: "80", ptr: new(*uint), value: uintp(0)},
	{input: "C0", ptr: new(*uint), error: "rlp: expected input string or byte for uint"},
753
	{input: "07", ptr: new(*uint), value: uintp(7)},
754 755
	{input: "817F", ptr: new(*uint), error: "rlp: non-canonical size information for uint"},
	{input: "8180", ptr: new(*uint), value: uintp(0x80)},
756
	{input: "C109", ptr: new(*[]uint), value: &[]uint{9}},
757 758
	{input: "C58403030303", ptr: new(*[][]byte), value: &[][]byte{{3, 3, 3, 3}}},

Felix Lange's avatar
Felix Lange committed
759
	// check that input position is advanced also for empty values.
760
	{input: "C3808005", ptr: new([]*uint), value: []*uint{uintp(0), uintp(0), uintp(5)}},
Felix Lange's avatar
Felix Lange committed
761

762 763 764 765 766 767 768
	// interface{}
	{input: "00", ptr: new(interface{}), value: []byte{0}},
	{input: "01", ptr: new(interface{}), value: []byte{1}},
	{input: "80", ptr: new(interface{}), value: []byte{}},
	{input: "850505050505", ptr: new(interface{}), value: []byte{5, 5, 5, 5, 5}},
	{input: "C0", ptr: new(interface{}), value: []interface{}{}},
	{input: "C50183040404", ptr: new(interface{}), value: []interface{}{[]byte{1}, []byte{4, 4, 4}}},
769 770 771 772 773
	{
		input: "C3010203",
		ptr:   new([]io.Reader),
		error: "rlp: type io.Reader is not RLP-serializable",
	},
774 775 776 777 778 779 780

	// fuzzer crashes
	{
		input: "c330f9c030f93030ce3030303030303030bd303030303030",
		ptr:   new(interface{}),
		error: "rlp: element is larger than containing list",
	},
781 782
}

783
func uintp(i uint) *uint { return &i }
784

785
func runTests(t *testing.T, decode func([]byte, interface{}) error) {
786 787 788 789 790 791
	for i, test := range decodeTests {
		input, err := hex.DecodeString(test.input)
		if err != nil {
			t.Errorf("test %d: invalid hex input %q", i, test.input)
			continue
		}
792
		err = decode(input, test.ptr)
793
		if err != nil && test.error == "" {
794 795 796 797
			t.Errorf("test %d: unexpected Decode error: %v\ndecoding into %T\ninput %q",
				i, err, test.ptr, test.input)
			continue
		}
798
		if test.error != "" && fmt.Sprint(err) != test.error {
799 800 801 802 803 804 805 806 807 808 809 810
			t.Errorf("test %d: Decode error mismatch\ngot  %v\nwant %v\ndecoding into %T\ninput %q",
				i, err, test.error, test.ptr, test.input)
			continue
		}
		deref := reflect.ValueOf(test.ptr).Elem().Interface()
		if err == nil && !reflect.DeepEqual(deref, test.value) {
			t.Errorf("test %d: value mismatch\ngot  %#v\nwant %#v\ndecoding into %T\ninput %q",
				i, deref, test.value, test.ptr, test.input)
		}
	}
}

811 812 813 814 815 816
func TestDecodeWithByteReader(t *testing.T) {
	runTests(t, func(input []byte, into interface{}) error {
		return Decode(bytes.NewReader(input), into)
	})
}

817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836
func testDecodeWithEncReader(t *testing.T, n int) {
	s := strings.Repeat("0", n)
	_, r, _ := EncodeToReader(s)
	var decoded string
	err := Decode(r, &decoded)
	if err != nil {
		t.Errorf("Unexpected decode error with n=%v: %v", n, err)
	}
	if decoded != s {
		t.Errorf("Decode mismatch with n=%v", n)
	}
}

// This is a regression test checking that decoding from encReader
// works for RLP values of size 8192 bytes or more.
func TestDecodeWithEncReader(t *testing.T) {
	testDecodeWithEncReader(t, 8188) // length with header is 8191
	testDecodeWithEncReader(t, 8189) // length with header is 8192
}

837 838 839 840 841 842 843 844 845
// plainReader reads from a byte slice but does not
// implement ReadByte. It is also not recognized by the
// size validation. This is useful to test how the decoder
// behaves on a non-buffered input stream.
type plainReader []byte

func newPlainReader(b []byte) io.Reader {
	return (*plainReader)(&b)
}
846

847
func (r *plainReader) Read(buf []byte) (n int, err error) {
848 849 850 851 852 853 854 855 856 857
	if len(*r) == 0 {
		return 0, io.EOF
	}
	n = copy(buf, *r)
	*r = (*r)[n:]
	return n, nil
}

func TestDecodeWithNonByteReader(t *testing.T) {
	runTests(t, func(input []byte, into interface{}) error {
858
		return Decode(newPlainReader(input), into)
859 860 861 862
	})
}

func TestDecodeStreamReset(t *testing.T) {
863
	s := NewStream(nil, 0)
864
	runTests(t, func(input []byte, into interface{}) error {
865
		s.Reset(bytes.NewReader(input), 0)
866 867 868 869
		return s.Decode(into)
	})
}

870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906
type testDecoder struct{ called bool }

func (t *testDecoder) DecodeRLP(s *Stream) error {
	if _, err := s.Uint(); err != nil {
		return err
	}
	t.called = true
	return nil
}

func TestDecodeDecoder(t *testing.T) {
	var s struct {
		T1 testDecoder
		T2 *testDecoder
		T3 **testDecoder
	}
	if err := Decode(bytes.NewReader(unhex("C3010203")), &s); err != nil {
		t.Fatalf("Decode error: %v", err)
	}

	if !s.T1.called {
		t.Errorf("DecodeRLP was not called for (non-pointer) testDecoder")
	}

	if s.T2 == nil {
		t.Errorf("*testDecoder has not been allocated")
	} else if !s.T2.called {
		t.Errorf("DecodeRLP was not called for *testDecoder")
	}

	if s.T3 == nil || *s.T3 == nil {
		t.Errorf("**testDecoder has not been allocated")
	} else if !(*s.T3).called {
		t.Errorf("DecodeRLP was not called for **testDecoder")
	}
}

907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922
func TestDecodeDecoderNilPointer(t *testing.T) {
	var s struct {
		T1 *testDecoder `rlp:"nil"`
		T2 *testDecoder
	}
	if err := Decode(bytes.NewReader(unhex("C2C002")), &s); err != nil {
		t.Fatalf("Decode error: %v", err)
	}
	if s.T1 != nil {
		t.Errorf("decoder T1 allocated for empty input (called: %v)", s.T1.called)
	}
	if s.T2 == nil || !s.T2.called {
		t.Errorf("decoder T2 not allocated/called")
	}
}

923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952
type byteDecoder byte

func (bd *byteDecoder) DecodeRLP(s *Stream) error {
	_, err := s.Uint()
	*bd = 255
	return err
}

func (bd byteDecoder) called() bool {
	return bd == 255
}

// This test verifies that the byte slice/byte array logic
// does not kick in for element types implementing Decoder.
func TestDecoderInByteSlice(t *testing.T) {
	var slice []byteDecoder
	if err := Decode(bytes.NewReader(unhex("C101")), &slice); err != nil {
		t.Errorf("unexpected Decode error %v", err)
	} else if !slice[0].called() {
		t.Errorf("DecodeRLP not called for slice element")
	}

	var array [1]byteDecoder
	if err := Decode(bytes.NewReader(unhex("C101")), &array); err != nil {
		t.Errorf("unexpected Decode error %v", err)
	} else if !array[0].called() {
		t.Errorf("DecodeRLP not called for array element")
	}
}

953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973
type unencodableDecoder func()

func (f *unencodableDecoder) DecodeRLP(s *Stream) error {
	if _, err := s.List(); err != nil {
		return err
	}
	if err := s.ListEnd(); err != nil {
		return err
	}
	*f = func() {}
	return nil
}

func TestDecoderFunc(t *testing.T) {
	var x func()
	if err := DecodeBytes([]byte{0xC0}, (*unencodableDecoder)(&x)); err != nil {
		t.Fatal(err)
	}
	x()
}

974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007
// This tests the validity checks for fields with struct tag "optional".
func TestInvalidOptionalField(t *testing.T) {
	type (
		invalid1 struct {
			A uint `rlp:"optional"`
			B uint
		}
		invalid2 struct {
			T []uint `rlp:"tail,optional"`
		}
		invalid3 struct {
			T []uint `rlp:"optional,tail"`
		}
	)

	tests := []struct {
		v   interface{}
		err string
	}{
		{v: new(invalid1), err: `rlp: struct field rlp.invalid1.B needs "optional" tag`},
		{v: new(invalid2), err: `rlp: invalid struct tag "optional" for rlp.invalid2.T (also has "tail" tag)`},
		{v: new(invalid3), err: `rlp: invalid struct tag "tail" for rlp.invalid3.T (also has "optional" tag)`},
	}
	for _, test := range tests {
		err := DecodeBytes(unhex("C20102"), test.v)
		if err == nil {
			t.Errorf("no error for %T", test.v)
		} else if err.Error() != test.err {
			t.Errorf("wrong error for %T: %v", test.v, err.Error())
		}
	}

}

1008 1009 1010 1011
func ExampleDecode() {
	input, _ := hex.DecodeString("C90A1486666F6F626172")

	type example struct {
1012 1013
		A, B   uint
		String string
1014 1015 1016 1017 1018 1019 1020 1021 1022 1023
	}

	var s example
	err := Decode(bytes.NewReader(input), &s)
	if err != nil {
		fmt.Printf("Error: %v\n", err)
	} else {
		fmt.Printf("Decoded value: %#v\n", s)
	}
	// Output:
1024
	// Decoded value: rlp.example{A:0xa, B:0x14, String:"foobar"}
1025 1026
}

1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053
func ExampleDecode_structTagNil() {
	// In this example, we'll use the "nil" struct tag to change
	// how a pointer-typed field is decoded. The input contains an RLP
	// list of one element, an empty string.
	input := []byte{0xC1, 0x80}

	// This type uses the normal rules.
	// The empty input string is decoded as a pointer to an empty Go string.
	var normalRules struct {
		String *string
	}
	Decode(bytes.NewReader(input), &normalRules)
	fmt.Printf("normal: String = %q\n", *normalRules.String)

	// This type uses the struct tag.
	// The empty input string is decoded as a nil pointer.
	var withEmptyOK struct {
		String *string `rlp:"nil"`
	}
	Decode(bytes.NewReader(input), &withEmptyOK)
	fmt.Printf("with nil tag: String = %v\n", withEmptyOK.String)

	// Output:
	// normal: String = ""
	// with nil tag: String = <nil>
}

1054 1055
func ExampleStream() {
	input, _ := hex.DecodeString("C90A1486666F6F626172")
1056
	s := NewStream(bytes.NewReader(input), 0)
1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083

	// Check what kind of value lies ahead
	kind, size, _ := s.Kind()
	fmt.Printf("Kind: %v size:%d\n", kind, size)

	// Enter the list
	if _, err := s.List(); err != nil {
		fmt.Printf("List error: %v\n", err)
		return
	}

	// Decode elements
	fmt.Println(s.Uint())
	fmt.Println(s.Uint())
	fmt.Println(s.Bytes())

	// Acknowledge end of list
	if err := s.ListEnd(); err != nil {
		fmt.Printf("ListEnd error: %v\n", err)
	}
	// Output:
	// Kind: List size:9
	// 10 <nil>
	// 20 <nil>
	// [102 111 111 98 97 114] <nil>
}

1084
func BenchmarkDecodeUints(b *testing.B) {
1085
	enc := encodeTestSlice(90000)
1086 1087 1088 1089 1090
	b.SetBytes(int64(len(enc)))
	b.ReportAllocs()
	b.ResetTimer()

	for i := 0; i < b.N; i++ {
Felix Lange's avatar
Felix Lange committed
1091
		var s []uint
1092 1093 1094 1095 1096 1097 1098
		r := bytes.NewReader(enc)
		if err := Decode(r, &s); err != nil {
			b.Fatalf("Decode error: %v", err)
		}
	}
}

1099
func BenchmarkDecodeUintsReused(b *testing.B) {
1100
	enc := encodeTestSlice(100000)
1101 1102 1103 1104
	b.SetBytes(int64(len(enc)))
	b.ReportAllocs()
	b.ResetTimer()

Felix Lange's avatar
Felix Lange committed
1105
	var s []uint
1106 1107 1108 1109 1110 1111 1112 1113
	for i := 0; i < b.N; i++ {
		r := bytes.NewReader(enc)
		if err := Decode(r, &s); err != nil {
			b.Fatalf("Decode error: %v", err)
		}
	}
}

1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151
func BenchmarkDecodeByteArrayStruct(b *testing.B) {
	enc, err := EncodeToBytes(&byteArrayStruct{})
	if err != nil {
		b.Fatal(err)
	}
	b.SetBytes(int64(len(enc)))
	b.ReportAllocs()
	b.ResetTimer()

	var out byteArrayStruct
	for i := 0; i < b.N; i++ {
		if err := DecodeBytes(enc, &out); err != nil {
			b.Fatal(err)
		}
	}
}

func BenchmarkDecodeBigInts(b *testing.B) {
	ints := make([]*big.Int, 200)
	for i := range ints {
		ints[i] = math.BigPow(2, int64(i))
	}
	enc, err := EncodeToBytes(ints)
	if err != nil {
		b.Fatal(err)
	}
	b.SetBytes(int64(len(enc)))
	b.ReportAllocs()
	b.ResetTimer()

	var out []*big.Int
	for i := 0; i < b.N; i++ {
		if err := DecodeBytes(enc, &out); err != nil {
			b.Fatal(err)
		}
	}
}

Felix Lange's avatar
Felix Lange committed
1152 1153 1154
func encodeTestSlice(n uint) []byte {
	s := make([]uint, n)
	for i := uint(0); i < n; i++ {
1155 1156
		s[i] = i
	}
Felix Lange's avatar
Felix Lange committed
1157 1158 1159 1160 1161
	b, err := EncodeToBytes(s)
	if err != nil {
		panic(fmt.Sprintf("encode error: %v", err))
	}
	return b
1162 1163 1164
}

func unhex(str string) []byte {
Felix Lange's avatar
Felix Lange committed
1165
	b, err := hex.DecodeString(strings.Replace(str, " ", "", -1))
1166 1167 1168 1169 1170
	if err != nil {
		panic(fmt.Sprintf("invalid hex string: %q", str))
	}
	return b
}