iterator_test.go 11 KB
Newer Older
1
// Copyright 2014 The go-ethereum Authors
2
// This file is part of the go-ethereum library.
3
//
4
// The go-ethereum library is free software: you can redistribute it and/or modify
5 6 7 8
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
9
// The go-ethereum library is distributed in the hope that it will be useful,
10
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 13 14
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
15
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
16

17
package trie
obscuren's avatar
obscuren committed
18

19
import (
20 21
	"bytes"
	"fmt"
22
	"math/rand"
23 24 25 26 27
	"testing"

	"github.com/ethereum/go-ethereum/common"
	"github.com/ethereum/go-ethereum/ethdb"
)
obscuren's avatar
obscuren committed
28 29

func TestIterator(t *testing.T) {
Felix Lange's avatar
Felix Lange committed
30
	trie := newEmpty()
obscuren's avatar
obscuren committed
31 32 33 34
	vals := []struct{ k, v string }{
		{"do", "verb"},
		{"ether", "wookiedoo"},
		{"horse", "stallion"},
35 36 37 38
		{"shaman", "horse"},
		{"doge", "coin"},
		{"dog", "puppy"},
		{"somethingveryoddindeedthis is", "myothernodedata"},
obscuren's avatar
obscuren committed
39
	}
40
	all := make(map[string]string)
obscuren's avatar
obscuren committed
41
	for _, val := range vals {
42
		all[val.k] = val.v
Felix Lange's avatar
Felix Lange committed
43
		trie.Update([]byte(val.k), []byte(val.v))
obscuren's avatar
obscuren committed
44
	}
45
	trie.Commit(nil)
obscuren's avatar
obscuren committed
46

47
	found := make(map[string]string)
48
	it := NewIterator(trie.NodeIterator(nil))
obscuren's avatar
obscuren committed
49
	for it.Next() {
50
		found[string(it.Key)] = string(it.Value)
obscuren's avatar
obscuren committed
51 52
	}

53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77
	for k, v := range all {
		if found[k] != v {
			t.Errorf("iterator value mismatch for %s: got %q want %q", k, found[k], v)
		}
	}
}

type kv struct {
	k, v []byte
	t    bool
}

func TestIteratorLargeData(t *testing.T) {
	trie := newEmpty()
	vals := make(map[string]*kv)

	for i := byte(0); i < 255; i++ {
		value := &kv{common.LeftPadBytes([]byte{i}, 32), []byte{i}, false}
		value2 := &kv{common.LeftPadBytes([]byte{10, i}, 32), []byte{i}, false}
		trie.Update(value.k, value.v)
		trie.Update(value2.k, value2.v)
		vals[string(value.k)] = value
		vals[string(value2.k)] = value2
	}

78
	it := NewIterator(trie.NodeIterator(nil))
79 80 81 82 83 84 85 86 87 88 89 90 91 92 93
	for it.Next() {
		vals[string(it.Key)].t = true
	}

	var untouched []*kv
	for _, value := range vals {
		if !value.t {
			untouched = append(untouched, value)
		}
	}

	if len(untouched) > 0 {
		t.Errorf("Missed %d nodes", len(untouched))
		for _, value := range untouched {
			t.Error(value)
obscuren's avatar
obscuren committed
94 95 96
		}
	}
}
97 98 99 100 101 102 103 104

// Tests that the node iterator indeed walks over the entire database contents.
func TestNodeIteratorCoverage(t *testing.T) {
	// Create some arbitrary test trie to iterate
	db, trie, _ := makeTestTrie()

	// Gather all the node hashes found by the iterator
	hashes := make(map[common.Hash]struct{})
105
	for it := trie.NodeIterator(nil); it.Next(true); {
106 107
		if it.Hash() != (common.Hash{}) {
			hashes[it.Hash()] = struct{}{}
108 109 110
		}
	}
	// Cross check the hashes and the database itself
Felix Lange's avatar
Felix Lange committed
111
	for hash := range hashes {
112
		if _, err := db.Node(hash); err != nil {
113 114 115
			t.Errorf("failed to retrieve reported node %x: %v", hash, err)
		}
	}
116 117 118 119 120 121 122 123
	for hash, obj := range db.nodes {
		if obj != nil && hash != (common.Hash{}) {
			if _, ok := hashes[hash]; !ok {
				t.Errorf("state entry not reported %x", hash)
			}
		}
	}
	for _, key := range db.diskdb.(*ethdb.MemDatabase).Keys() {
124 125 126 127 128
		if _, ok := hashes[common.BytesToHash(key)]; !ok {
			t.Errorf("state entry not reported %x", key)
		}
	}
}
129

130 131 132
type kvs struct{ k, v string }

var testdata1 = []kvs{
133 134
	{"barb", "ba"},
	{"bard", "bc"},
135 136
	{"bars", "bb"},
	{"bar", "b"},
137 138 139
	{"fab", "z"},
	{"food", "ab"},
	{"foos", "aa"},
140
	{"foo", "a"},
141 142
}

143
var testdata2 = []kvs{
144 145 146 147 148 149 150 151 152 153 154
	{"aardvark", "c"},
	{"bar", "b"},
	{"barb", "bd"},
	{"bars", "be"},
	{"fab", "z"},
	{"foo", "a"},
	{"foos", "aa"},
	{"food", "ab"},
	{"jars", "d"},
}

155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
func TestIteratorSeek(t *testing.T) {
	trie := newEmpty()
	for _, val := range testdata1 {
		trie.Update([]byte(val.k), []byte(val.v))
	}

	// Seek to the middle.
	it := NewIterator(trie.NodeIterator([]byte("fab")))
	if err := checkIteratorOrder(testdata1[4:], it); err != nil {
		t.Fatal(err)
	}

	// Seek to a non-existent key.
	it = NewIterator(trie.NodeIterator([]byte("barc")))
	if err := checkIteratorOrder(testdata1[1:], it); err != nil {
		t.Fatal(err)
	}

	// Seek beyond the end.
	it = NewIterator(trie.NodeIterator([]byte("z")))
	if err := checkIteratorOrder(nil, it); err != nil {
		t.Fatal(err)
	}
}

func checkIteratorOrder(want []kvs, it *Iterator) error {
	for it.Next() {
		if len(want) == 0 {
			return fmt.Errorf("didn't expect any more values, got key %q", it.Key)
		}
		if !bytes.Equal(it.Key, []byte(want[0].k)) {
			return fmt.Errorf("wrong key: got %q, want %q", it.Key, want[0].k)
		}
		want = want[1:]
	}
	if len(want) > 0 {
		return fmt.Errorf("iterator ended early, want key %q", want[0])
	}
	return nil
}

196 197
func TestDifferenceIterator(t *testing.T) {
	triea := newEmpty()
198
	for _, val := range testdata1 {
199 200
		triea.Update([]byte(val.k), []byte(val.v))
	}
201
	triea.Commit(nil)
202 203

	trieb := newEmpty()
204
	for _, val := range testdata2 {
205 206
		trieb.Update([]byte(val.k), []byte(val.v))
	}
207
	trieb.Commit(nil)
208 209

	found := make(map[string]string)
210
	di, _ := NewDifferenceIterator(triea.NodeIterator(nil), trieb.NodeIterator(nil))
211
	it := NewIterator(di)
212 213 214 215 216 217 218 219 220 221 222 223
	for it.Next() {
		found[string(it.Key)] = string(it.Value)
	}

	all := []struct{ k, v string }{
		{"aardvark", "c"},
		{"barb", "bd"},
		{"bars", "be"},
		{"jars", "d"},
	}
	for _, item := range all {
		if found[item.k] != item.v {
224
			t.Errorf("iterator value mismatch for %s: got %v want %v", item.k, found[item.k], item.v)
225 226 227 228 229 230
		}
	}
	if len(found) != len(all) {
		t.Errorf("iterator count mismatch: got %d values, want %d", len(found), len(all))
	}
}
231 232 233 234 235 236

func TestUnionIterator(t *testing.T) {
	triea := newEmpty()
	for _, val := range testdata1 {
		triea.Update([]byte(val.k), []byte(val.v))
	}
237
	triea.Commit(nil)
238 239 240 241 242

	trieb := newEmpty()
	for _, val := range testdata2 {
		trieb.Update([]byte(val.k), []byte(val.v))
	}
243
	trieb.Commit(nil)
244

245
	di, _ := NewUnionIterator([]NodeIterator{triea.NodeIterator(nil), trieb.NodeIterator(nil)})
246
	it := NewIterator(di)
247 248 249 250

	all := []struct{ k, v string }{
		{"aardvark", "c"},
		{"barb", "ba"},
251
		{"barb", "bd"},
252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277
		{"bard", "bc"},
		{"bars", "bb"},
		{"bars", "be"},
		{"bar", "b"},
		{"fab", "z"},
		{"food", "ab"},
		{"foos", "aa"},
		{"foo", "a"},
		{"jars", "d"},
	}

	for i, kv := range all {
		if !it.Next() {
			t.Errorf("Iterator ends prematurely at element %d", i)
		}
		if kv.k != string(it.Key) {
			t.Errorf("iterator value mismatch for element %d: got key %s want %s", i, it.Key, kv.k)
		}
		if kv.v != string(it.Value) {
			t.Errorf("iterator value mismatch for element %d: got value %s want %s", i, it.Value, kv.v)
		}
	}
	if it.Next() {
		t.Errorf("Iterator returned extra values.")
	}
}
278 279 280 281 282 283 284 285 286 287

func TestIteratorNoDups(t *testing.T) {
	var tr Trie
	for _, val := range testdata1 {
		tr.Update([]byte(val.k), []byte(val.v))
	}
	checkIteratorNoDups(t, tr.NodeIterator(nil), nil)
}

// This test checks that nodeIterator.Next can be retried after inserting missing trie nodes.
288 289 290 291 292 293 294 295
func TestIteratorContinueAfterErrorDisk(t *testing.T)    { testIteratorContinueAfterError(t, false) }
func TestIteratorContinueAfterErrorMemonly(t *testing.T) { testIteratorContinueAfterError(t, true) }

func testIteratorContinueAfterError(t *testing.T, memonly bool) {
	diskdb, _ := ethdb.NewMemDatabase()
	triedb := NewDatabase(diskdb)

	tr, _ := New(common.Hash{}, triedb)
296 297 298
	for _, val := range testdata1 {
		tr.Update([]byte(val.k), []byte(val.v))
	}
299 300 301 302
	tr.Commit(nil)
	if !memonly {
		triedb.Commit(tr.Hash(), true)
	}
303 304
	wantNodeCount := checkIteratorNoDups(t, tr.NodeIterator(nil), nil)

305 306 307 308 309 310 311 312 313
	var (
		diskKeys [][]byte
		memKeys  []common.Hash
	)
	if memonly {
		memKeys = triedb.Nodes()
	} else {
		diskKeys = diskdb.Keys()
	}
314 315
	for i := 0; i < 20; i++ {
		// Create trie that will load all nodes from DB.
316
		tr, _ := New(tr.Hash(), triedb)
317 318 319

		// Remove a random node from the database. It can't be the root node
		// because that one is already loaded.
320 321 322 323 324
		var (
			rkey common.Hash
			rval []byte
			robj *cachedNode
		)
325
		for {
326 327 328 329 330 331
			if memonly {
				rkey = memKeys[rand.Intn(len(memKeys))]
			} else {
				copy(rkey[:], diskKeys[rand.Intn(len(diskKeys))])
			}
			if rkey != tr.Hash() {
332 333 334
				break
			}
		}
335 336 337 338 339 340 341
		if memonly {
			robj = triedb.nodes[rkey]
			delete(triedb.nodes, rkey)
		} else {
			rval, _ = diskdb.Get(rkey[:])
			diskdb.Delete(rkey[:])
		}
342 343 344 345 346
		// Iterate until the error is hit.
		seen := make(map[string]bool)
		it := tr.NodeIterator(nil)
		checkIteratorNoDups(t, it, seen)
		missing, ok := it.Error().(*MissingNodeError)
347
		if !ok || missing.NodeHash != rkey {
348 349 350 351
			t.Fatal("didn't hit missing node, got", it.Error())
		}

		// Add the node back and continue iteration.
352 353 354 355 356
		if memonly {
			triedb.nodes[rkey] = robj
		} else {
			diskdb.Put(rkey[:], rval)
		}
357 358 359 360 361 362 363 364 365 366 367 368 369
		checkIteratorNoDups(t, it, seen)
		if it.Error() != nil {
			t.Fatal("unexpected error", it.Error())
		}
		if len(seen) != wantNodeCount {
			t.Fatal("wrong node iteration count, got", len(seen), "want", wantNodeCount)
		}
	}
}

// Similar to the test above, this one checks that failure to create nodeIterator at a
// certain key prefix behaves correctly when Next is called. The expectation is that Next
// should retry seeking before returning true for the first time.
370 371 372 373 374 375 376 377
func TestIteratorContinueAfterSeekErrorDisk(t *testing.T) {
	testIteratorContinueAfterSeekError(t, false)
}
func TestIteratorContinueAfterSeekErrorMemonly(t *testing.T) {
	testIteratorContinueAfterSeekError(t, true)
}

func testIteratorContinueAfterSeekError(t *testing.T, memonly bool) {
378
	// Commit test trie to db, then remove the node containing "bars".
379 380 381 382
	diskdb, _ := ethdb.NewMemDatabase()
	triedb := NewDatabase(diskdb)

	ctr, _ := New(common.Hash{}, triedb)
383 384 385
	for _, val := range testdata1 {
		ctr.Update([]byte(val.k), []byte(val.v))
	}
386 387 388 389
	root, _ := ctr.Commit(nil)
	if !memonly {
		triedb.Commit(root, true)
	}
390
	barNodeHash := common.HexToHash("05041990364eb72fcb1127652ce40d8bab765f2bfe53225b1170d276cc101c2e")
391 392 393 394 395 396 397 398 399 400 401
	var (
		barNodeBlob []byte
		barNodeObj  *cachedNode
	)
	if memonly {
		barNodeObj = triedb.nodes[barNodeHash]
		delete(triedb.nodes, barNodeHash)
	} else {
		barNodeBlob, _ = diskdb.Get(barNodeHash[:])
		diskdb.Delete(barNodeHash[:])
	}
402 403
	// Create a new iterator that seeks to "bars". Seeking can't proceed because
	// the node is missing.
404
	tr, _ := New(root, triedb)
405 406 407 408 409 410 411 412
	it := tr.NodeIterator([]byte("bars"))
	missing, ok := it.Error().(*MissingNodeError)
	if !ok {
		t.Fatal("want MissingNodeError, got", it.Error())
	} else if missing.NodeHash != barNodeHash {
		t.Fatal("wrong node missing")
	}
	// Reinsert the missing node.
413 414 415 416 417
	if memonly {
		triedb.nodes[barNodeHash] = barNodeObj
	} else {
		diskdb.Put(barNodeHash[:], barNodeBlob)
	}
418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435
	// Check that iteration produces the right set of values.
	if err := checkIteratorOrder(testdata1[2:], NewIterator(it)); err != nil {
		t.Fatal(err)
	}
}

func checkIteratorNoDups(t *testing.T, it NodeIterator, seen map[string]bool) int {
	if seen == nil {
		seen = make(map[string]bool)
	}
	for it.Next(true) {
		if seen[string(it.Path())] {
			t.Fatalf("iterator visited node path %x twice", it.Path())
		}
		seen[string(it.Path())] = true
	}
	return len(seen)
}