difflayer.go 22.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
// Copyright 2019 The go-ethereum Authors
// This file is part of the go-ethereum library.
//
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// The go-ethereum library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

package snapshot

import (
20
	"encoding/binary"
21
	"fmt"
22
	"math"
23
	"math/rand"
24
	"sync"
25
	"sync/atomic"
26
	"time"
27 28

	"github.com/ethereum/go-ethereum/common"
29
	"github.com/ethereum/go-ethereum/core/types"
30
	"github.com/ethereum/go-ethereum/rlp"
31
	bloomfilter "github.com/holiman/bloomfilter/v2"
32
	"golang.org/x/exp/slices"
33 34 35 36 37 38 39 40 41 42 43 44 45 46
)

var (
	// aggregatorMemoryLimit is the maximum size of the bottom-most diff layer
	// that aggregates the writes from above until it's flushed into the disk
	// layer.
	//
	// Note, bumping this up might drastically increase the size of the bloom
	// filters that's stored in every diff layer. Don't do that without fully
	// understanding all the implications.
	aggregatorMemoryLimit = uint64(4 * 1024 * 1024)

	// aggregatorItemLimit is an approximate number of items that will end up
	// in the agregator layer before it's flushed out to disk. A plain account
47
	// weighs around 14B (+hash), a storage slot 32B (+hash), a deleted slot
48
	// 0B (+hash). Slots are mostly set/unset in lockstep, so that average at
49 50 51
	// 16B (+hash). All in all, the average entry seems to be 15+32=47B. Use a
	// smaller number to be on the safe side.
	aggregatorItemLimit = aggregatorMemoryLimit / 42
52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69

	// bloomTargetError is the target false positive rate when the aggregator
	// layer is at its fullest. The actual value will probably move around up
	// and down from this number, it's mostly a ballpark figure.
	//
	// Note, dropping this down might drastically increase the size of the bloom
	// filters that's stored in every diff layer. Don't do that without fully
	// understanding all the implications.
	bloomTargetError = 0.02

	// bloomSize is the ideal bloom filter size given the maximum number of items
	// it's expected to hold and the target false positive error rate.
	bloomSize = math.Ceil(float64(aggregatorItemLimit) * math.Log(bloomTargetError) / math.Log(1/math.Pow(2, math.Log(2))))

	// bloomFuncs is the ideal number of bits a single entry should set in the
	// bloom filter to keep its size to a minimum (given it's size and maximum
	// entry count).
	bloomFuncs = math.Round((bloomSize / float64(aggregatorItemLimit)) * math.Log(2))
70

71
	// the bloom offsets are runtime constants which determines which part of the
72
	// account/storage hash the hasher functions looks at, to determine the
73 74 75
	// bloom key for an account/slot. This is randomized at init(), so that the
	// global population of nodes do not all display the exact same behaviour with
	// regards to bloom content
76 77 78
	bloomDestructHasherOffset = 0
	bloomAccountHasherOffset  = 0
	bloomStorageHasherOffset  = 0
79 80
)

81
func init() {
82 83 84 85 86 87 88 89 90 91 92
	// Init the bloom offsets in the range [0:24] (requires 8 bytes)
	bloomDestructHasherOffset = rand.Intn(25)
	bloomAccountHasherOffset = rand.Intn(25)
	bloomStorageHasherOffset = rand.Intn(25)

	// The destruct and account blooms must be different, as the storage slots
	// will check for destruction too for every bloom miss. It should not collide
	// with modified accounts.
	for bloomAccountHasherOffset == bloomDestructHasherOffset {
		bloomAccountHasherOffset = rand.Intn(25)
	}
93 94
}

95 96 97 98 99 100 101
// diffLayer represents a collection of modifications made to a state snapshot
// after running a block on top. It contains one sorted list for the account trie
// and one-one list for each storage tries.
//
// The goal of a diff layer is to act as a journal, tracking recent modifications
// made to the state, that have not yet graduated into a semi-immutable state.
type diffLayer struct {
102 103 104
	origin *diskLayer // Base disk layer to directly use on bloom misses
	parent snapshot   // Parent snapshot modified by this one, never nil
	memory uint64     // Approximate guess as to how much memory we use
105

106
	root  common.Hash // Root hash to which this snapshot diff belongs to
107
	stale atomic.Bool // Signals that the layer became stale (state progressed)
108

109 110 111 112 113 114 115
	// destructSet is a very special helper marker. If an account is marked as
	// deleted, then it's recorded in this set. However it's allowed that an account
	// is included here but still available in other sets(e.g. storageData). The
	// reason is the diff layer includes all the changes in a *block*. It can
	// happen that in the tx_1, account A is self-destructed while in the tx_2
	// it's recreated. But we still need this marker to indicate the "old" A is
	// deleted, all data in other set belongs to the "new" A.
116
	destructSet map[common.Hash]struct{}               // Keyed markers for deleted (and potentially) recreated accounts
117
	accountList []common.Hash                          // List of account for iteration. If it exists, it's sorted, otherwise it's nil
118
	accountData map[common.Hash][]byte                 // Keyed accounts for direct retrieval (nil means deleted)
119
	storageList map[common.Hash][]common.Hash          // List of storage slots for iterated retrievals, one per account. Any existing lists are sorted if non-nil
120
	storageData map[common.Hash]map[common.Hash][]byte // Keyed storage slots for direct retrieval. one per account (nil means deleted)
121

122 123
	diffed *bloomfilter.Filter // Bloom filter tracking all the diffed items up to the disk layer

124 125 126
	lock sync.RWMutex
}

127 128 129 130 131 132 133 134 135 136 137 138 139 140
// destructBloomHasher is a wrapper around a common.Hash to satisfy the interface
// API requirements of the bloom library used. It's used to convert a destruct
// event into a 64 bit mini hash.
type destructBloomHasher common.Hash

func (h destructBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
func (h destructBloomHasher) Sum(b []byte) []byte               { panic("not implemented") }
func (h destructBloomHasher) Reset()                            { panic("not implemented") }
func (h destructBloomHasher) BlockSize() int                    { panic("not implemented") }
func (h destructBloomHasher) Size() int                         { return 8 }
func (h destructBloomHasher) Sum64() uint64 {
	return binary.BigEndian.Uint64(h[bloomDestructHasherOffset : bloomDestructHasherOffset+8])
}

141 142 143 144 145 146 147 148 149 150 151
// accountBloomHasher is a wrapper around a common.Hash to satisfy the interface
// API requirements of the bloom library used. It's used to convert an account
// hash into a 64 bit mini hash.
type accountBloomHasher common.Hash

func (h accountBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
func (h accountBloomHasher) Sum(b []byte) []byte               { panic("not implemented") }
func (h accountBloomHasher) Reset()                            { panic("not implemented") }
func (h accountBloomHasher) BlockSize() int                    { panic("not implemented") }
func (h accountBloomHasher) Size() int                         { return 8 }
func (h accountBloomHasher) Sum64() uint64 {
152
	return binary.BigEndian.Uint64(h[bloomAccountHasherOffset : bloomAccountHasherOffset+8])
153 154 155 156 157 158 159 160 161 162 163 164 165
}

// storageBloomHasher is a wrapper around a [2]common.Hash to satisfy the interface
// API requirements of the bloom library used. It's used to convert an account
// hash into a 64 bit mini hash.
type storageBloomHasher [2]common.Hash

func (h storageBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
func (h storageBloomHasher) Sum(b []byte) []byte               { panic("not implemented") }
func (h storageBloomHasher) Reset()                            { panic("not implemented") }
func (h storageBloomHasher) BlockSize() int                    { panic("not implemented") }
func (h storageBloomHasher) Size() int                         { return 8 }
func (h storageBloomHasher) Sum64() uint64 {
166 167
	return binary.BigEndian.Uint64(h[0][bloomStorageHasherOffset:bloomStorageHasherOffset+8]) ^
		binary.BigEndian.Uint64(h[1][bloomStorageHasherOffset:bloomStorageHasherOffset+8])
168 169
}

170 171
// newDiffLayer creates a new diff on top of an existing snapshot, whether that's a low
// level persistent database or a hierarchical diff already.
172
func newDiffLayer(parent snapshot, root common.Hash, destructs map[common.Hash]struct{}, accounts map[common.Hash][]byte, storage map[common.Hash]map[common.Hash][]byte) *diffLayer {
173 174 175 176
	// Create the new layer with some pre-allocated data segments
	dl := &diffLayer{
		parent:      parent,
		root:        root,
177
		destructSet: destructs,
178 179
		accountData: accounts,
		storageData: storage,
180
		storageList: make(map[common.Hash][]common.Hash),
181
	}
182 183 184 185 186 187 188 189
	switch parent := parent.(type) {
	case *diskLayer:
		dl.rebloom(parent)
	case *diffLayer:
		dl.rebloom(parent.origin)
	default:
		panic("unknown parent type")
	}
190 191 192 193 194
	// Sanity check that accounts or storage slots are never nil
	for accountHash, blob := range accounts {
		if blob == nil {
			panic(fmt.Sprintf("account %#x nil", accountHash))
		}
195 196 197
		// Determine memory size and track the dirty writes
		dl.memory += uint64(common.HashLength + len(blob))
		snapshotDirtyAccountWriteMeter.Mark(int64(len(blob)))
198 199 200 201 202
	}
	for accountHash, slots := range storage {
		if slots == nil {
			panic(fmt.Sprintf("storage %#x nil", accountHash))
		}
203
		// Determine memory size and track the dirty writes
204
		for _, data := range slots {
205 206
			dl.memory += uint64(common.HashLength + len(data))
			snapshotDirtyStorageWriteMeter.Mark(int64(len(data)))
207 208
		}
	}
209
	dl.memory += uint64(len(destructs) * common.HashLength)
210 211 212
	return dl
}

213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
// rebloom discards the layer's current bloom and rebuilds it from scratch based
// on the parent's and the local diffs.
func (dl *diffLayer) rebloom(origin *diskLayer) {
	dl.lock.Lock()
	defer dl.lock.Unlock()

	defer func(start time.Time) {
		snapshotBloomIndexTimer.Update(time.Since(start))
	}(time.Now())

	// Inject the new origin that triggered the rebloom
	dl.origin = origin

	// Retrieve the parent bloom or create a fresh empty one
	if parent, ok := dl.parent.(*diffLayer); ok {
		parent.lock.RLock()
		dl.diffed, _ = parent.diffed.Copy()
		parent.lock.RUnlock()
	} else {
		dl.diffed, _ = bloomfilter.New(uint64(bloomSize), uint64(bloomFuncs))
	}
	// Iterate over all the accounts and storage slots and index them
235 236 237
	for hash := range dl.destructSet {
		dl.diffed.Add(destructBloomHasher(hash))
	}
238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254
	for hash := range dl.accountData {
		dl.diffed.Add(accountBloomHasher(hash))
	}
	for accountHash, slots := range dl.storageData {
		for storageHash := range slots {
			dl.diffed.Add(storageBloomHasher{accountHash, storageHash})
		}
	}
	// Calculate the current false positive rate and update the error rate meter.
	// This is a bit cheating because subsequent layers will overwrite it, but it
	// should be fine, we're only interested in ballpark figures.
	k := float64(dl.diffed.K())
	n := float64(dl.diffed.N())
	m := float64(dl.diffed.M())
	snapshotBloomErrorGauge.Update(math.Pow(1.0-math.Exp((-k)*(n+0.5)/(m-1)), k))
}

255 256 257 258 259
// Root returns the root hash for which this snapshot was made.
func (dl *diffLayer) Root() common.Hash {
	return dl.root
}

260 261
// Parent returns the subsequent layer of a diff layer.
func (dl *diffLayer) Parent() snapshot {
262 263 264
	dl.lock.RLock()
	defer dl.lock.RUnlock()

265 266 267
	return dl.parent
}

268 269 270
// Stale return whether this layer has become stale (was flattened across) or if
// it's still live.
func (dl *diffLayer) Stale() bool {
271
	return dl.stale.Load()
272 273 274 275
}

// Account directly retrieves the account associated with a particular hash in
// the snapshot slim data format.
276
func (dl *diffLayer) Account(hash common.Hash) (*types.SlimAccount, error) {
277 278 279 280
	data, err := dl.AccountRLP(hash)
	if err != nil {
		return nil, err
	}
281
	if len(data) == 0 { // can be both nil and []byte{}
282
		return nil, nil
283
	}
284
	account := new(types.SlimAccount)
285 286 287
	if err := rlp.DecodeBytes(data, account); err != nil {
		panic(err)
	}
288
	return account, nil
289 290 291 292
}

// AccountRLP directly retrieves the account RLP associated with a particular
// hash in the snapshot slim data format.
293 294
//
// Note the returned account is not a copy, please don't modify it.
295
func (dl *diffLayer) AccountRLP(hash common.Hash) ([]byte, error) {
296
	// Check staleness before reaching further.
297
	dl.lock.RLock()
298 299 300 301
	if dl.Stale() {
		dl.lock.RUnlock()
		return nil, ErrSnapshotStale
	}
302 303 304
	// Check the bloom filter first whether there's even a point in reaching into
	// all the maps in all the layers below
	hit := dl.diffed.Contains(accountBloomHasher(hash))
305 306 307
	if !hit {
		hit = dl.diffed.Contains(destructBloomHasher(hash))
	}
308 309 310 311
	var origin *diskLayer
	if !hit {
		origin = dl.origin // extract origin while holding the lock
	}
312 313 314 315
	dl.lock.RUnlock()

	// If the bloom filter misses, don't even bother with traversing the memory
	// diff layers, reach straight into the bottom persistent disk layer
316
	if origin != nil {
317
		snapshotBloomAccountMissMeter.Mark(1)
318
		return origin.AccountRLP(hash)
319 320
	}
	// The bloom filter hit, start poking in the internal maps
321
	return dl.accountRLP(hash, 0)
322 323 324 325 326
}

// accountRLP is an internal version of AccountRLP that skips the bloom filter
// checks and uses the internal maps to try and retrieve the data. It's meant
// to be used if a higher layer's bloom filter hit already.
327
func (dl *diffLayer) accountRLP(hash common.Hash, depth int) ([]byte, error) {
328 329 330
	dl.lock.RLock()
	defer dl.lock.RUnlock()

331 332
	// If the layer was flattened into, consider it invalid (any live reference to
	// the original should be marked as unusable).
333
	if dl.Stale() {
334 335
		return nil, ErrSnapshotStale
	}
336
	// If the account is known locally, return it
337
	if data, ok := dl.accountData[hash]; ok {
338
		snapshotDirtyAccountHitMeter.Mark(1)
339
		snapshotDirtyAccountHitDepthHist.Update(int64(depth))
340
		snapshotDirtyAccountReadMeter.Mark(int64(len(data)))
341
		snapshotBloomAccountTrueHitMeter.Mark(1)
342
		return data, nil
343
	}
344 345 346 347 348 349 350 351
	// If the account is known locally, but deleted, return it
	if _, ok := dl.destructSet[hash]; ok {
		snapshotDirtyAccountHitMeter.Mark(1)
		snapshotDirtyAccountHitDepthHist.Update(int64(depth))
		snapshotDirtyAccountInexMeter.Mark(1)
		snapshotBloomAccountTrueHitMeter.Mark(1)
		return nil, nil
	}
352
	// Account unknown to this diff, resolve from parent
353
	if diff, ok := dl.parent.(*diffLayer); ok {
354
		return diff.accountRLP(hash, depth+1)
355 356 357
	}
	// Failed to resolve through diff layers, mark a bloom error and use the disk
	snapshotBloomAccountFalseHitMeter.Mark(1)
358 359 360 361 362 363
	return dl.parent.AccountRLP(hash)
}

// Storage directly retrieves the storage data associated with a particular hash,
// within a particular account. If the slot is unknown to this diff, it's parent
// is consulted.
364 365
//
// Note the returned slot is not a copy, please don't modify it.
366
func (dl *diffLayer) Storage(accountHash, storageHash common.Hash) ([]byte, error) {
367 368 369
	// Check the bloom filter first whether there's even a point in reaching into
	// all the maps in all the layers below
	dl.lock.RLock()
370 371 372 373 374
	// Check staleness before reaching further.
	if dl.Stale() {
		dl.lock.RUnlock()
		return nil, ErrSnapshotStale
	}
375
	hit := dl.diffed.Contains(storageBloomHasher{accountHash, storageHash})
376 377 378
	if !hit {
		hit = dl.diffed.Contains(destructBloomHasher(accountHash))
	}
379 380 381 382
	var origin *diskLayer
	if !hit {
		origin = dl.origin // extract origin while holding the lock
	}
383 384 385 386
	dl.lock.RUnlock()

	// If the bloom filter misses, don't even bother with traversing the memory
	// diff layers, reach straight into the bottom persistent disk layer
387
	if origin != nil {
388
		snapshotBloomStorageMissMeter.Mark(1)
389
		return origin.Storage(accountHash, storageHash)
390 391
	}
	// The bloom filter hit, start poking in the internal maps
392
	return dl.storage(accountHash, storageHash, 0)
393 394 395 396 397
}

// storage is an internal version of Storage that skips the bloom filter checks
// and uses the internal maps to try and retrieve the data. It's meant  to be
// used if a higher layer's bloom filter hit already.
398
func (dl *diffLayer) storage(accountHash, storageHash common.Hash, depth int) ([]byte, error) {
399 400 401
	dl.lock.RLock()
	defer dl.lock.RUnlock()

402 403
	// If the layer was flattened into, consider it invalid (any live reference to
	// the original should be marked as unusable).
404
	if dl.Stale() {
405 406
		return nil, ErrSnapshotStale
	}
407
	// If the account is known locally, try to resolve the slot locally
408 409
	if storage, ok := dl.storageData[accountHash]; ok {
		if data, ok := storage[storageHash]; ok {
410
			snapshotDirtyStorageHitMeter.Mark(1)
411 412 413 414 415 416
			snapshotDirtyStorageHitDepthHist.Update(int64(depth))
			if n := len(data); n > 0 {
				snapshotDirtyStorageReadMeter.Mark(int64(n))
			} else {
				snapshotDirtyStorageInexMeter.Mark(1)
			}
417
			snapshotBloomStorageTrueHitMeter.Mark(1)
418
			return data, nil
419 420
		}
	}
421 422 423 424 425 426 427 428
	// If the account is known locally, but deleted, return an empty slot
	if _, ok := dl.destructSet[accountHash]; ok {
		snapshotDirtyStorageHitMeter.Mark(1)
		snapshotDirtyStorageHitDepthHist.Update(int64(depth))
		snapshotDirtyStorageInexMeter.Mark(1)
		snapshotBloomStorageTrueHitMeter.Mark(1)
		return nil, nil
	}
429 430
	// Storage slot unknown to this diff, resolve from parent
	if diff, ok := dl.parent.(*diffLayer); ok {
431
		return diff.storage(accountHash, storageHash, depth+1)
432 433 434
	}
	// Failed to resolve through diff layers, mark a bloom error and use the disk
	snapshotBloomStorageFalseHitMeter.Mark(1)
435 436 437 438 439
	return dl.parent.Storage(accountHash, storageHash)
}

// Update creates a new layer on top of the existing snapshot diff tree with
// the specified data items.
440 441
func (dl *diffLayer) Update(blockRoot common.Hash, destructs map[common.Hash]struct{}, accounts map[common.Hash][]byte, storage map[common.Hash]map[common.Hash][]byte) *diffLayer {
	return newDiffLayer(dl, blockRoot, destructs, accounts, storage)
442 443 444 445
}

// flatten pushes all data from this point downwards, flattening everything into
// a single diff at the bottom. Since usually the lowermost diff is the largest,
446
// the flattening builds up from there in reverse.
447 448 449 450 451 452 453 454 455 456 457
func (dl *diffLayer) flatten() snapshot {
	// If the parent is not diff, we're the first in line, return unmodified
	parent, ok := dl.parent.(*diffLayer)
	if !ok {
		return dl
	}
	// Parent is a diff, flatten it first (note, apart from weird corned cases,
	// flatten will realistically only ever merge 1 layer, so there's no need to
	// be smarter about grouping flattens together).
	parent = parent.flatten().(*diffLayer)

458 459 460 461 462
	parent.lock.Lock()
	defer parent.lock.Unlock()

	// Before actually writing all our data to the parent, first ensure that the
	// parent hasn't been 'corrupted' by someone else already flattening into it
463
	if parent.stale.Swap(true) {
464 465
		panic("parent diff layer is stale") // we've flattened into the same parent from two children, boo
	}
466
	// Overwrite all the updated accounts blindly, merge the sorted list
467 468 469 470 471
	for hash := range dl.destructSet {
		parent.destructSet[hash] = struct{}{}
		delete(parent.accountData, hash)
		delete(parent.storageData, hash)
	}
472 473 474
	for hash, data := range dl.accountData {
		parent.accountData[hash] = data
	}
475
	// Overwrite all the updated storage slots (individually)
476
	for accountHash, storage := range dl.storageData {
477 478
		// If storage didn't exist (or was deleted) in the parent, overwrite blindly
		if _, ok := parent.storageData[accountHash]; !ok {
479 480 481 482 483 484 485 486 487 488
			parent.storageData[accountHash] = storage
			continue
		}
		// Storage exists in both parent and child, merge the slots
		comboData := parent.storageData[accountHash]
		for storageHash, data := range storage {
			comboData[storageHash] = data
		}
	}
	// Return the combo parent
489 490
	return &diffLayer{
		parent:      parent.parent,
491
		origin:      parent.origin,
492
		root:        dl.root,
493
		destructSet: parent.destructSet,
494
		accountData: parent.accountData,
495 496
		storageData: parent.storageData,
		storageList: make(map[common.Hash][]common.Hash),
497
		diffed:      dl.diffed,
498 499
		memory:      parent.memory + dl.memory,
	}
500 501
}

502
// AccountList returns a sorted list of all accounts in this diffLayer, including
503 504 505
// the deleted ones.
//
// Note, the returned slice is not a copy, so do not modify it.
506
func (dl *diffLayer) AccountList() []common.Hash {
507 508 509 510 511 512 513 514 515
	// If an old list already exists, return it
	dl.lock.RLock()
	list := dl.accountList
	dl.lock.RUnlock()

	if list != nil {
		return list
	}
	// No old sorted account list exists, generate a new one
516 517
	dl.lock.Lock()
	defer dl.lock.Unlock()
518

519
	dl.accountList = make([]common.Hash, 0, len(dl.destructSet)+len(dl.accountData))
520 521
	for hash := range dl.accountData {
		dl.accountList = append(dl.accountList, hash)
522
	}
523 524 525 526 527
	for hash := range dl.destructSet {
		if _, ok := dl.accountData[hash]; !ok {
			dl.accountList = append(dl.accountList, hash)
		}
	}
528
	slices.SortFunc(dl.accountList, common.Hash.Less)
529
	dl.memory += uint64(len(dl.accountList) * common.HashLength)
530 531 532
	return dl.accountList
}

533
// StorageList returns a sorted list of all storage slot hashes in this diffLayer
534 535 536 537 538 539
// for the given account. If the whole storage is destructed in this layer, then
// an additional flag *destructed = true* will be returned, otherwise the flag is
// false. Besides, the returned list will include the hash of deleted storage slot.
// Note a special case is an account is deleted in a prior tx but is recreated in
// the following tx with some storage slots set. In this case the returned list is
// not empty but the flag is true.
540 541
//
// Note, the returned slice is not a copy, so do not modify it.
542
func (dl *diffLayer) StorageList(accountHash common.Hash) ([]common.Hash, bool) {
543
	dl.lock.RLock()
544
	_, destructed := dl.destructSet[accountHash]
545 546 547 548 549
	if _, ok := dl.storageData[accountHash]; !ok {
		// Account not tracked by this layer
		dl.lock.RUnlock()
		return nil, destructed
	}
550
	// If an old list already exists, return it
551 552
	if list, exist := dl.storageList[accountHash]; exist {
		dl.lock.RUnlock()
553
		return list, destructed // the cached list can't be nil
554
	}
555 556 557
	dl.lock.RUnlock()

	// No old sorted account list exists, generate a new one
558 559
	dl.lock.Lock()
	defer dl.lock.Unlock()
560 561 562

	storageMap := dl.storageData[accountHash]
	storageList := make([]common.Hash, 0, len(storageMap))
563
	for k := range storageMap {
564
		storageList = append(storageList, k)
565
	}
566
	slices.SortFunc(storageList, common.Hash.Less)
567
	dl.storageList[accountHash] = storageList
568 569
	dl.memory += uint64(len(dl.storageList)*common.HashLength + common.HashLength)
	return storageList, destructed
570
}