api_test.go 9.04 KB
Newer Older
1
// Copyright 2018 The go-ethereum Authors
2
// This file is part of the go-ethereum library.
3
//
4 5
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
6 7 8
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
9
// The go-ethereum library is distributed in the hope that it will be useful,
10 11
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12
// GNU Lesser General Public License for more details.
13
//
14 15 16
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

17
package core_test
18 19 20 21 22 23 24 25 26 27 28

import (
	"bytes"
	"context"
	"fmt"
	"math/big"
	"os"
	"path/filepath"
	"testing"
	"time"

29
	"github.com/ethereum/go-ethereum/accounts"
30 31 32 33 34 35
	"github.com/ethereum/go-ethereum/accounts/keystore"
	"github.com/ethereum/go-ethereum/common"
	"github.com/ethereum/go-ethereum/common/hexutil"
	"github.com/ethereum/go-ethereum/core/types"
	"github.com/ethereum/go-ethereum/internal/ethapi"
	"github.com/ethereum/go-ethereum/rlp"
36
	"github.com/ethereum/go-ethereum/signer/core"
37
	"github.com/ethereum/go-ethereum/signer/core/apitypes"
38
	"github.com/ethereum/go-ethereum/signer/fourbyte"
39
	"github.com/ethereum/go-ethereum/signer/storage"
40 41 42
)

//Used for testing
43 44 45
type headlessUi struct {
	approveCh chan string // to send approve/deny
	inputCh   chan string // to send password
46 47
}

48
func (ui *headlessUi) OnInputRequired(info core.UserInputRequest) (core.UserInputResponse, error) {
49
	input := <-ui.inputCh
50
	return core.UserInputResponse{Text: input}, nil
51 52
}

53 54
func (ui *headlessUi) OnSignerStartup(info core.StartupInfo)        {}
func (ui *headlessUi) RegisterUIServer(api *core.UIServerAPI)       {}
55
func (ui *headlessUi) OnApprovedTx(tx ethapi.SignTransactionResult) {}
56

57
func (ui *headlessUi) ApproveTx(request *core.SignTxRequest) (core.SignTxResponse, error) {
58

59
	switch <-ui.approveCh {
60
	case "Y":
61
		return core.SignTxResponse{request.Transaction, true}, nil
62 63
	case "M": // modify
		// The headless UI always modifies the transaction
64 65 66
		old := big.Int(request.Transaction.Value)
		newVal := big.NewInt(0).Add(&old, big.NewInt(1))
		request.Transaction.Value = hexutil.Big(*newVal)
67
		return core.SignTxResponse{request.Transaction, true}, nil
68
	default:
69
		return core.SignTxResponse{request.Transaction, false}, nil
70 71
	}
}
72

73
func (ui *headlessUi) ApproveSignData(request *core.SignDataRequest) (core.SignDataResponse, error) {
74
	approved := (<-ui.approveCh == "Y")
75
	return core.SignDataResponse{approved}, nil
76 77
}

78
func (ui *headlessUi) ApproveListing(request *core.ListRequest) (core.ListResponse, error) {
79 80 81
	approval := <-ui.approveCh
	//fmt.Printf("approval %s\n", approval)
	switch approval {
82
	case "A":
83
		return core.ListResponse{request.Accounts}, nil
84
	case "1":
85
		l := make([]accounts.Account, 1)
86
		l[0] = request.Accounts[1]
87
		return core.ListResponse{l}, nil
88
	default:
89
		return core.ListResponse{nil}, nil
90 91 92
	}
}

93
func (ui *headlessUi) ApproveNewAccount(request *core.NewAccountRequest) (core.NewAccountResponse, error) {
94
	if <-ui.approveCh == "Y" {
95
		return core.NewAccountResponse{true}, nil
96
	}
97
	return core.NewAccountResponse{false}, nil
98
}
99

100
func (ui *headlessUi) ShowError(message string) {
101
	//stdout is used by communication
102
	fmt.Fprintln(os.Stderr, message)
103
}
104

105
func (ui *headlessUi) ShowInfo(message string) {
106
	//stdout is used by communication
107
	fmt.Fprintln(os.Stderr, message)
108 109 110
}

func tmpDirName(t *testing.T) string {
111 112
	d := t.TempDir()
	d, err := filepath.EvalSymlinks(d)
113 114 115 116 117 118
	if err != nil {
		t.Fatal(err)
	}
	return d
}

119 120
func setup(t *testing.T) (*core.SignerAPI, *headlessUi) {
	db, err := fourbyte.New()
121
	if err != nil {
122
		t.Fatal(err.Error())
123
	}
124
	ui := &headlessUi{make(chan string, 20), make(chan string, 20)}
125
	am := core.StartClefAccountManager(tmpDirName(t), true, true, "")
126
	api := core.NewSignerAPI(am, 1337, true, ui, db, true, &storage.NoStorage{})
127
	return api, ui
128

129
}
130
func createAccount(ui *headlessUi, api *core.SignerAPI, t *testing.T) {
131 132
	ui.approveCh <- "Y"
	ui.inputCh <- "a_long_password"
133 134 135 136 137 138 139
	_, err := api.New(context.Background())
	if err != nil {
		t.Fatal(err)
	}
	// Some time to allow changes to propagate
	time.Sleep(250 * time.Millisecond)
}
140

141
func failCreateAccountWithPassword(ui *headlessUi, api *core.SignerAPI, password string, t *testing.T) {
142

143 144 145 146 147
	ui.approveCh <- "Y"
	// We will be asked three times to provide a suitable password
	ui.inputCh <- password
	ui.inputCh <- password
	ui.inputCh <- password
148

149
	addr, err := api.New(context.Background())
150 151 152
	if err == nil {
		t.Fatal("Should have returned an error")
	}
153
	if addr != (common.Address{}) {
154 155 156 157
		t.Fatal("Empty address should be returned")
	}
}

158
func failCreateAccount(ui *headlessUi, api *core.SignerAPI, t *testing.T) {
159
	ui.approveCh <- "N"
160
	addr, err := api.New(context.Background())
161
	if err != core.ErrRequestDenied {
162 163
		t.Fatal(err)
	}
164
	if addr != (common.Address{}) {
165 166 167
		t.Fatal("Empty address should be returned")
	}
}
168

169
func list(ui *headlessUi, api *core.SignerAPI, t *testing.T) ([]common.Address, error) {
170 171 172
	ui.approveCh <- "A"
	return api.List(context.Background())

173 174 175 176 177
}

func TestNewAcc(t *testing.T) {
	api, control := setup(t)
	verifyNum := func(num int) {
178 179 180 181 182
		list, err := list(control, api, t)
		if err != nil {
			t.Errorf("Unexpected error %v", err)
		}
		if len(list) != num {
183 184 185 186 187 188 189 190 191 192 193 194
			t.Errorf("Expected %d accounts, got %d", num, len(list))
		}
	}
	// Testing create and create-deny
	createAccount(control, api, t)
	createAccount(control, api, t)
	failCreateAccount(control, api, t)
	failCreateAccount(control, api, t)
	createAccount(control, api, t)
	failCreateAccount(control, api, t)
	createAccount(control, api, t)
	failCreateAccount(control, api, t)
195 196 197 198 199
	verifyNum(4)

	// Fail to create this, due to bad password
	failCreateAccountWithPassword(control, api, "short", t)
	failCreateAccountWithPassword(control, api, "longerbutbad\rfoo", t)
200 201 202 203
	verifyNum(4)

	// Testing listing:
	// Listing one Account
204
	control.approveCh <- "1"
205 206 207 208 209 210 211 212
	list, err := api.List(context.Background())
	if err != nil {
		t.Fatal(err)
	}
	if len(list) != 1 {
		t.Fatalf("List should only show one Account")
	}
	// Listing denied
213
	control.approveCh <- "Nope"
214 215 216 217
	list, err = api.List(context.Background())
	if len(list) != 0 {
		t.Fatalf("List should be empty")
	}
218
	if err != core.ErrRequestDenied {
219 220 221 222
		t.Fatal("Expected deny")
	}
}

223
func mkTestTx(from common.MixedcaseAddress) apitypes.SendTxArgs {
224 225 226 227 228 229
	to := common.NewMixedcaseAddress(common.HexToAddress("0x1337"))
	gas := hexutil.Uint64(21000)
	gasPrice := (hexutil.Big)(*big.NewInt(2000000000))
	value := (hexutil.Big)(*big.NewInt(1e18))
	nonce := (hexutil.Uint64)(0)
	data := hexutil.Bytes(common.Hex2Bytes("01020304050607080a"))
230
	tx := apitypes.SendTxArgs{
231 232 233
		From:     from,
		To:       &to,
		Gas:      gas,
234
		GasPrice: &gasPrice,
235 236 237 238 239 240 241 242
		Value:    value,
		Data:     &data,
		Nonce:    nonce}
	return tx
}

func TestSignTx(t *testing.T) {
	var (
243
		list      []common.Address
244 245 246 247 248 249
		res, res2 *ethapi.SignTransactionResult
		err       error
	)

	api, control := setup(t)
	createAccount(control, api, t)
250
	control.approveCh <- "A"
251 252 253 254
	list, err = api.List(context.Background())
	if err != nil {
		t.Fatal(err)
	}
255 256 257
	if len(list) == 0 {
		t.Fatal("Unexpected empty list")
	}
258
	a := common.NewMixedcaseAddress(list[0])
259 260 261 262

	methodSig := "test(uint)"
	tx := mkTestTx(a)

263 264
	control.approveCh <- "Y"
	control.inputCh <- "wrongpassword"
265 266 267 268 269 270 271
	res, err = api.SignTransaction(context.Background(), tx, &methodSig)
	if res != nil {
		t.Errorf("Expected nil-response, got %v", res)
	}
	if err != keystore.ErrDecrypt {
		t.Errorf("Expected ErrLocked! %v", err)
	}
272
	control.approveCh <- "No way"
273 274 275 276
	res, err = api.SignTransaction(context.Background(), tx, &methodSig)
	if res != nil {
		t.Errorf("Expected nil-response, got %v", res)
	}
277
	if err != core.ErrRequestDenied {
278 279
		t.Errorf("Expected ErrRequestDenied! %v", err)
	}
280 281 282
	// Sign with correct password
	control.approveCh <- "Y"
	control.inputCh <- "a_long_password"
283 284 285 286 287 288 289
	res, err = api.SignTransaction(context.Background(), tx, &methodSig)

	if err != nil {
		t.Fatal(err)
	}
	parsedTx := &types.Transaction{}
	rlp.Decode(bytes.NewReader(res.Raw), parsedTx)
290

291 292 293 294
	//The tx should NOT be modified by the UI
	if parsedTx.Value().Cmp(tx.Value.ToInt()) != 0 {
		t.Errorf("Expected value to be unchanged, expected %v got %v", tx.Value, parsedTx.Value())
	}
295 296
	control.approveCh <- "Y"
	control.inputCh <- "a_long_password"
297 298 299 300 301 302 303 304 305 306

	res2, err = api.SignTransaction(context.Background(), tx, &methodSig)
	if err != nil {
		t.Fatal(err)
	}
	if !bytes.Equal(res.Raw, res2.Raw) {
		t.Error("Expected tx to be unmodified by UI")
	}

	//The tx is modified by the UI
307 308
	control.approveCh <- "M"
	control.inputCh <- "a_long_password"
309 310 311 312 313 314 315

	res2, err = api.SignTransaction(context.Background(), tx, &methodSig)
	if err != nil {
		t.Fatal(err)
	}
	parsedTx2 := &types.Transaction{}
	rlp.Decode(bytes.NewReader(res.Raw), parsedTx2)
316

317 318 319 320 321 322 323 324 325
	//The tx should be modified by the UI
	if parsedTx2.Value().Cmp(tx.Value.ToInt()) != 0 {
		t.Errorf("Expected value to be unchanged, got %v", parsedTx.Value())
	}
	if bytes.Equal(res.Raw, res2.Raw) {
		t.Error("Expected tx to be modified by UI")
	}

}