Merge pull request #154 from skalenetwork/bug/SKALE-3114-bls-sign-error

SKALE-3114 fix bls import/sign error

BLSCrypto.cpp

@@ -248,11 +248,7 @@ std::string encryptBLSKeyShare2Hex(int *errStatus, char *err_string, const char
     auto encryptedKey = make_shared<vector<uint8_t>>(BUF_LEN, 0);
     auto errMsg = make_shared<vector<char>>(BUF_LEN, 0);
 
-    libff::alt_bn128_Fr key(_key);
-
-    string str_key = BLSutils::ConvertToString(key);
-
-    strncpy(keyArray->data(), str_key.data(), BUF_LEN);
+    strncpy(keyArray->data(), _key, BUF_LEN);
     *errStatus = -1;
 
     unsigned int encryptedLen = 0;
@@ -268,7 +264,7 @@ std::string encryptBLSKeyShare2Hex(int *errStatus, char *err_string, const char
 
     if (status != SGX_SUCCESS) {
         *errStatus = -1;
-        return nullptr;
+        return "";
     }
 
     std::string result(2 * BUF_LEN, '\0');

run_sgx_sim/docker-compose.yml

@@ -16,5 +16,4 @@ services:
         max-size: "10m"
         max-file: "4"
     restart: unless-stopped
-    command: -s  
-
+    command: -s -y

secure_enclave/EnclaveCommon.cpp

@@ -145,8 +145,10 @@ libff::alt_bn128_Fr *keyFromString(const char *_keyStringHex) {
     SAFE_CHAR_BUF(skey_dec, BUF_LEN);
     libff::alt_bn128_Fr *ret = nullptr;
 
+    if (mpz_set_str(skey, _keyStringHex, 16) == -1) {
+        goto clean;
+    }
 
-    mpz_set_str(skey, _keyStringHex, 16);
     mpz_get_str(skey_dec, 10, skey);
 
     ret = new libff::alt_bn128_Fr(skey_dec);

secure_enclave/secure_enclave.c

@@ -668,7 +668,12 @@ void trustedBlsSignMessageAES(int *errStatus, char *errString, uint8_t *encrypte
 
     CHECK_STATUS("AES decrypt failed")
 
-    enclave_sign(key, _hashX, _hashY, sig);
+    if (!enclave_sign(key, _hashX, _hashY, sig)) {
+        strncpy(errString, "Enclave failed to create bls signature", BUF_LEN);
+        LOG_ERROR(errString);
+        *errStatus = -1;
+        goto clean;
+    }
 
     strncpy(signature, sig, BUF_LEN);