SKALE-2794 fix codacy issues

DKGCrypto.cpp

@@ -156,8 +156,8 @@ vector<vector<string>> get_verif_vect(const char *encryptedPolyHex, int t, int n
 string trustedGetSecretShares(const string &_polyName, const char *_encryptedPolyHex, const vector<string> &_publicKeys,
                               int _t,
                               int _n) {
+    vector<char> hexEncrKey(2 * BUF_LEN, 0);
     vector<char> errMsg1(BUF_LEN, 0);
-    vector<char> hexEncrKey(BUF_LEN, 0);
     int errStatus = 0;
     uint64_t encLen = 0;
 

SGXWalletServer.cpp

@@ -219,7 +219,7 @@ SGXWalletServer::blsSignMessageHashImpl(const string &_keyShareName, const strin
         }
 
         value = readFromDb(_keyShareName);
-    } catch (SGXException _e) {
+    } catch (SGXException& _e) {
         result["status"] = _e.status;
         result["errorMessage"] = _e.errString;
         return result;
@@ -786,7 +786,7 @@ void SGXWalletServer::writeDataToDB(const string &Name, const string &value) {
     Json::FastWriter writer;
 
     val["value"] = value;
-    string json = writer.write(val);
+    writer.write(val);
 
     auto key = Name;
 

TestUtils.cpp

@@ -256,7 +256,7 @@ void TestUtils::sendRPCRequest() {
         sigShareSet.addSigShare(make_shared<BLSSigShare>(sig));
     }
 
-    shared_ptr <BLSSignature> commonSig = sigShareSet.merge();
+    sigShareSet.merge();
 }
 
 void TestUtils::destroyEnclave() {

secure_enclave/DKGUtils.cpp

@@ -72,7 +72,7 @@ template<class T> string ConvertToString(const T& field_elem, int base = 10) {
   return output;
 }
 
-string ConvertG2ToString(const libff::alt_bn128_G2 & elem, int base = 10, string delim = ":") {
+string ConvertG2ToString(const libff::alt_bn128_G2 & elem, int base = 10, const string& delim = ":") {
   string result;
   result += ConvertToString(elem.X.c0);
   result += delim;

testw.py

@@ -62,4 +62,4 @@ testList = [ "[cert-sign]",
 for t in testList:
     print("Starting " + t)
     assert subprocess.call(["./testw", t]) == 0
-    print("Ending " + t) 
+    print("Ending " + t)